Conversation
…of empty start event
This comment has been minimized.
This comment has been minimized.
| }; | ||
| } | ||
|
|
||
| const process = engine._versionProcessMapping[version]; |
There was a problem hiding this comment.
I think I wouldn't use these kinds of access to "private" members of the engine outside the file in which engine is defined. Maybe create a new function "isProcessVersionDeployed" similar to "undeployProcessVersion" in "engine.js" and check in there if the version is deployed in the execution environment.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| */ | ||
| isProcessVersionDeployed(versionId) { | ||
| const process = this._versionProcessMapping[versionId]; | ||
| if (!process) throw new Error(`Version ${versionId} is not deployed on this engine.`); |
There was a problem hiding this comment.
What I meant with "check if the version is deployed to this engine" was that you should check if the version is stored in the database of the engine. If not return an error.
If it is, check if the version is deployed. If the version or the entire process is not deployed just return {active: false} otherwise return the value of process.isDeployed();.
You already changed that you return a "success" with { active: false } when you cannot find an instance of this engine class for the process, which means the entire process was not deployed, so I think it is just consistent to do the same here (if (!process) return false;) when the version is not deployed.
There was a problem hiding this comment.
done. please have a look
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
2 participants
Summary
Instance select dropdown now shows the sorted instance (always new instance on top)
Reorganized the Start/Resume/Pause/Stop buttons:
Start new instance button is now conditionally shown based on whether the process has a plain start event.
Added new button with spinning green icon when process is active, static black when inactive. This Button only appears when the current process version has at least one Timer Start Event
Made the Resume/Pause/Stop group to a 2-icon-group. The Resume icon (Play symbol) instead of the Pause icon is now shown if the process is paused.
Added
GET /process/:definitionId/versions/:version/activeendpoint to retrieve the real activation state of a deployed process version from the engineActivation state is fetched from the backend on every page load so navigating away and back always reflects the real state