added filtering vacancies by is_active and project

removed unnecessary fields from Projects from VacanciesList

Author: VeryBigSad

vacancy/filters.py

@@ -0,0 +1,31 @@
+from django_filters import rest_framework as filters
+
+from vacancy.models import Vacancy
+
+
+class VacancyFilter(filters.FilterSet):
+    """Filter for Vacancies
+
+    Adds filtering to DRF list retrieve views
+
+    Parameters to filter by:
+        project (int), is_active (default to True if not set otherwise) (boolean)
+
+    Examples:
+        ?project=1 equals to .filter(project_id=1)
+        (no params passed) equals to .filter(is_active=True)
+        ?is_active=false equals to .filter(is_active=False)
+    """
+
+    def __init__(self, *args, **kwargs):
+        """if is_active filter is not passed, default to True"""
+        super().__init__(*args, **kwargs)
+        if self.data.get("is_active") is None:
+            self.data = dict(self.data)
+            self.data["is_active"] = True
+
+    is_active = filters.BooleanFilter(field_name="is_active")
+
+    class Meta:
+        model = Vacancy
+        fields = ("project", "is_active")

vacancy/managers.py

@@ -13,7 +13,6 @@ def get_vacancy_for_list_view(self):
                 "project__id",
                 "is_active",
             )
-            .filter(is_active=True)
         )
 
     def get_vacancy_for_detail_view(self):

vacancy/serializers.py

@@ -1,12 +1,24 @@
 from rest_framework import serializers
 
-from projects.serializers import ProjectListSerializer
+from projects.models import Project
 from users.serializers import UserSerializer
 from vacancy.models import Vacancy, VacancyResponse
 
 
+class ProjectForVacancySerializer(serializers.ModelSerializer):
+    class Meta:
+        model = Project
+        fields = [
+            "id",
+            "name",
+            "description",
+            "short_description",
+            "image_address",
+        ]
+
+
 class VacancyDetailSerializer(serializers.ModelSerializer):
-    project = ProjectListSerializer(many=False)
+    project = ProjectForVacancySerializer(many=False)
 
     class Meta:
         model = Vacancy

vacancy/views.py

@@ -1,7 +1,9 @@
+from django_filters import rest_framework as filters
 from rest_framework import generics, permissions, mixins, status
 from rest_framework.generics import GenericAPIView
 from rest_framework.response import Response
 
+from vacancy.filters import VacancyFilter
 from vacancy.models import Vacancy, VacancyResponse
 from vacancy.serializers import (
     VacancyDetailSerializer,
@@ -15,6 +17,8 @@ class VacancyList(generics.ListCreateAPIView):
     queryset = Vacancy.objects.get_vacancy_for_list_view()
     serializer_class = ProjectVacancyListSerializer
     permission_classes = [permissions.IsAuthenticatedOrReadOnly]
+    filter_backends = (filters.DjangoFilterBackend,)
+    filterset_class = VacancyFilter
 
 
 class VacancyDetail(generics.RetrieveUpdateDestroyAPIView):