Skip to content

Commit 187411c

Browse files
committed
Edited comments
1 parent 83fa88d commit 187411c

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

projects/views.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ class ProjectRecommendedUsers(generics.RetrieveAPIView):
112112

113113
def get(self, request, pk, **kwargs):
114114
project = self.get_object()
115-
# fixme: store key_skills and required_skills more convenient, not just as a string'
116115

116+
# fixme: store key_skills and required_skills more convenient, not just as a string
117117
all_needed_skills = set()
118118
for vacancy in project.vacancies.all():
119119
all_needed_skills.update(set(vacancy.required_skills.lower().split(",")))
@@ -122,9 +122,12 @@ def get(self, request, pk, **kwargs):
122122
for user in User.objects.get_members():
123123
if user == request.user or not user.key_skills:
124124
continue
125+
125126
skills = set(user.key_skills.lower().split(","))
126127
if skills.intersection(all_needed_skills):
127128
recommended_users.append(user)
129+
130+
# get some random users
128131
sampled_recommended_users = sample(
129132
recommended_users, min(RECOMMENDATIONS_COUNT, len(recommended_users))
130133
)
@@ -136,8 +139,6 @@ def get(self, request, pk, **kwargs):
136139
class ProjectCountView(generics.GenericAPIView):
137140
queryset = Project.objects.get_projects_for_count_view()
138141
serializer_class = ProjectListSerializer
139-
# TODO: using this permission could result in a user not having verified email
140-
# creating a project; probably should make IsUserVerifiedOrReadOnly
141142
permission_classes = [permissions.IsAuthenticated]
142143

143144
def get(self, request):

0 commit comments

Comments
 (0)