optimized some queries

Author: sh1nkey

chats/views.py

@@ -94,8 +94,9 @@ def get(self, request, *args, **kwargs) -> Response:
                 request.user.id == user1_id or request.user.id == user2_id
             ), "current user id is not present in raw id"
 
-            user1 = User.objects.get(pk=user1_id)
-            user2 = User.objects.get(pk=user2_id)
+            users = User.objects.filter(pk__in=[user1_id, user2_id])
+            user1 = users.get(pk=user1_id)
+            user2 = users.get(pk=user2_id)
 
             if user1 == request.user:
                 opponent = user2
@@ -117,7 +118,9 @@ def get(self, request, *args, **kwargs) -> Response:
         except ValueError:
             return Response(
                 status=status.HTTP_400_BAD_REQUEST,
-                data={"detail": "processed id must contain two integers separated by underscore"},
+                data={
+                    "detail": "processed id must contain two integers separated by underscore"
+                },
             )
         except AssertionError as e:
             return Response(status=status.HTTP_400_BAD_REQUEST, data={"detail": str(e)})

vacancy/views.py

@@ -48,12 +48,9 @@ def put(self, request, *args, **kwargs):
         if not request.data.get("is_active"):
             # automatically declining every vacancy response if the vacancy is not active
             vacancy = self.get_object()
-            vacancy_requests = VacancyResponse.objects.filter(
-                vacancy=vacancy, is_approved=None
+            VacancyResponse.objects.filter(vacancy=vacancy, is_approved=None).update(
+                is_approved=False
             )
-            for vacancy_request in vacancy_requests:
-                vacancy_request.is_approved = False
-                vacancy_request.save()
         return self.update(request, *args, **kwargs)