linter and naming update

Author: sh1nkey

rate_projects/constants.py

@@ -1,13 +1,8 @@
-TYPES = (
+VERBOSE_NAME_TYPES = (
     ("str", "Текст"),
     ("int", "Целочисленное число"),
     ("float", "Число с плавающей точкой"),
-    ("bool", "Да или нет")
+    ("bool", "Да или нет"),
 )
 
-get_type = {
-    "str": str,
-    "int": int,
-    "float": float,
-    "bool": bool
-}
+GET_TYPE_FROM_STRING = {"str": str, "int": int, "float": float, "bool": bool}

rate_projects/models.py

@@ -3,10 +3,11 @@
 
 from partner_programs.models import PartnerProgram
 from projects.models import Project
-from .constants import TYPES, get_type
+from .constants import TYPES
 
 User = get_user_model()
 
+
 class Criteria(models.Model):
     """
     Criteria model
@@ -20,32 +21,22 @@ class Criteria(models.Model):
         partner_program: A ForeignKey connection to PartnerProgram model
 
     """
-    name = models.CharField(
-        verbose_name="Название",
-        max_length=50
-    )
-    description = models.TextField(
-        verbose_name="Описание",
-        null=True,
-        blank=True
-    )
-    type = models.CharField(
-        verbose_name="Тип",
-        max_length=8,
-        choices=TYPES
-    )
+
+    name = models.CharField(verbose_name="Название", max_length=50)
+    description = models.TextField(verbose_name="Описание", null=True, blank=True)
+    type = models.CharField(verbose_name="Тип", max_length=8, choices=TYPES)
 
     min_value = models.FloatField(
         verbose_name="Минимально допустимое числовое значение",
         help_text="(если есть)",
         null=True,
-        blank=True
+        blank=True,
     )
     max_value = models.FloatField(
         verbose_name="Максимально допустимое числовое значение",
         help_text="(если есть)",
         null=True,
-        blank=True
+        blank=True,
     )
     partner_program = models.ForeignKey(
         PartnerProgram,
@@ -61,7 +52,6 @@ class Meta:
         verbose_name_plural = "Критерии оценки проектов"
 
 
-
 class ProjectScore(models.Model):
     """
     ProjectScore model
@@ -76,52 +66,30 @@ class ProjectScore(models.Model):
         value_str: IntegerField for value
 
     """
+
     criteria = models.ForeignKey(
-        Criteria,
-        on_delete=models.CASCADE,
-        related_name="scores"
-    )
-    user = models.ForeignKey(
-        User,
-        on_delete=models.CASCADE,
-        related_name="scores"
-    )
-    project = models.ForeignKey(
-        Project,
-        on_delete=models.CASCADE,
-        related_name="scores"
+        Criteria, on_delete=models.CASCADE, related_name="scores"
     )
+    user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="scores")
+    project = models.ForeignKey(Project, on_delete=models.CASCADE, related_name="scores")
 
     value_int = models.IntegerField(
-        verbose_name="Целочисленное значение",
-        null=True,
-        blank=True
+        verbose_name="Целочисленное значение", null=True, blank=True
     )
     value_float = models.FloatField(
-        verbose_name="Значение с плавающей запятой",
-        max_length=50,
-        null=True,
-        blank=True
+        verbose_name="Значение с плавающей запятой", max_length=50, null=True, blank=True
     )
     value_bool = models.BooleanField(
-        verbose_name="'Да или нет' значение",
-        null=True,
-        blank=True
+        verbose_name="'Да или нет' значение", null=True, blank=True
     )
     value_str = models.FloatField(
-        verbose_name="Текстовое значение",
-        max_length=50,
-        null=True,
-        blank=True
+        verbose_name="Текстовое значение", max_length=50, null=True, blank=True
     )
 
-
     def __str__(self):
         return f"ProjectScore<{self.id}> - {self.criteria.name}"
 
-
     class Meta:
         verbose_name = "Оценка проекта"
         verbose_name_plural = "Оценки проектов"
-        unique_together = ('criteria', 'user', 'project')
-
+        unique_together = ("criteria", "user", "project")