Merge pull request #231 from PROCOLLAB-github/feature/news-for-users

News for users

Author: VeryBigSad

news/mixins.py

@@ -1,33 +1,54 @@
+from django.contrib.auth import get_user_model
+
 from news.models import News
 from partner_programs.models import PartnerProgram
 from projects.models import Project
 
+User = get_user_model()
+
 
 class NewsQuerysetMixin:
     """
     Mixin for getting queryset for news
     """
 
     def get_queryset_for_project(self):
+        """Returns queryset of news for project"""
+        project_pk = self.kwargs.get("project_pk")
         try:
-            project = Project.objects.get(pk=self.kwargs.get("project_pk"))
+            project = Project.objects.get(pk=project_pk)
         except Project.DoesNotExist:
+            # TODO: raise http 404 here
             return News.objects.none()
         return News.objects.get_news(obj=project)
 
     def get_queryset_for_program(self):
+        """Returns queryset of news for partner program"""
+        partnerprogram_pk = self.kwargs.get("partnerprogram_pk")
         try:
-            program = PartnerProgram.objects.get(pk=self.kwargs.get("partnerprogram_pk"))
+            program = PartnerProgram.objects.get(pk=partnerprogram_pk)
         except PartnerProgram.DoesNotExist:
+            # TODO: raise http 404 here
             return News.objects.none()
         return News.objects.get_news(obj=program)
 
+    def get_queryset_for_user(self):
+        """Returns queryset of news for user"""
+        user_pk = self.kwargs.get("user_pk")
+        try:
+            user = User.objects.get(pk=user_pk)
+        except User.DoesNotExist:
+            # TODO: raise http 404 here
+            return News.objects.none()
+        return News.objects.get_news(obj=user)
+
     def get_queryset(self):
+        """Chooses what queryset to return - for project, program or user"""
         if self.kwargs.get("project_pk") is not None:
-            # it's a project
             return self.get_queryset_for_project()
         elif self.kwargs.get("partnerprogram_pk") is not None:
-            # it's a partner program
             return self.get_queryset_for_program()
+        elif self.kwargs.get("user_pk") is not None:
+            return self.get_queryset_for_user()
         else:
             return News.objects.none()

news/views.py

@@ -1,16 +1,20 @@
+from django.contrib.auth import get_user_model
+from django.shortcuts import get_object_or_404
 from rest_framework import generics, status
 from rest_framework.permissions import IsAuthenticated
 from rest_framework.response import Response
 
 from core.serializers import SetViewedSerializer, SetLikedSerializer
 from core.services import add_view, set_like
+from news.mixins import NewsQuerysetMixin
 from news.models import News
 from news.pagination import NewsPagination
 from news.permissions import IsNewsCreatorOrReadOnly
 from news.serializers import NewsListSerializer, NewsDetailSerializer
-from news.mixins import NewsQuerysetMixin
 from projects.models import Project
 
+User = get_user_model()
+
 
 class NewsList(NewsQuerysetMixin, generics.ListCreateAPIView):
     serializer_class = NewsListSerializer
@@ -19,14 +23,20 @@ class NewsList(NewsQuerysetMixin, generics.ListCreateAPIView):
 
     def post(self, request, *args, **kwargs):
         if kwargs.get("project_pk"):
-            project = Project.objects.get(pk=kwargs["project_pk"])
+            project = get_object_or_404(Project, pk=kwargs["project_pk"])
             news = News.objects.add_news(project, **request.data)
             return Response(
                 NewsDetailSerializer(news).data, status=status.HTTP_201_CREATED
             )
+        elif kwargs.get("user_pk"):
+            user = get_object_or_404(User, pk=kwargs["user_pk"])
+            news = News.objects.add_news(user, **request.data)
+            return Response(
+                NewsDetailSerializer(news).data, status=status.HTTP_201_CREATED
+            )
         else:
-            # creating partner program news, not implemented yet
-            raise NotImplementedError()
+            # creating partner program news, not implemented yet, return 400
+            return Response(status=status.HTTP_400_BAD_REQUEST)
 
     def get(self, request, *args, **kwargs):
         news = self.paginate_queryset(self.get_queryset())

users/urls.py

@@ -1,5 +1,6 @@
 from django.urls import path, re_path, include
 
+from news.views import NewsList, NewsDetail, NewsDetailSetViewed, NewsDetailSetLiked
 from users.views import (
     AchievementDetail,
     AchievementList,
@@ -35,6 +36,10 @@
     path("users/<int:pk>/", UserDetail.as_view()),
     path("users/<int:pk>/set_onboarding_stage/", SetUserOnboardingStage.as_view()),
     path("users/<int:pk>/force_verify/", ForceVerifyView.as_view()),
+    path("users/<int:user_pk>/news/", NewsList.as_view()),
+    path("users/<int:user_pk>/news/<int:pk>/", NewsDetail.as_view()),
+    path("users/<int:user_pk>/news/<int:pk>/set_viewed/", NewsDetailSetViewed.as_view()),
+    path("users/<int:user_pk>/news/<int:pk>/set_liked/", NewsDetailSetLiked.as_view()),
     path("users/current/", CurrentUser.as_view()),
     # todo: change password view
     path("users/current/programs/", CurrentUserPrograms.as_view()),