Finished simple stupid user recommendation

Author: yakser

projects/helpers.py projects/constants.pyprojects/helpers.py renamed to projects/constants.py

@@ -5,3 +5,5 @@
     (3, "Первые продажи"),
     (4, "Масштабирование"),
 )
+
+RECOMMENDATIONS_COUNT = 5

projects/models.py

@@ -4,7 +4,7 @@
 from django.db import models
 from django.db.models import UniqueConstraint
 from industries.models import Industry
-from projects.helpers import VERBOSE_STEPS
+from projects.constants import VERBOSE_STEPS
 from projects.managers import AchievementManager, ProjectManager
 from users.models import CustomUser
 

projects/permissions.py

@@ -17,7 +17,22 @@ def has_object_permission(self, request, view, obj):
             or obj.collaborator_set.filter(user=request.user).exists()
             or obj.invite_set.filter(user=request.user).exists()
         ):
+            return True
+        return False
+
+
+class IsProjectLeader(BasePermission):
+    """
+    Allows access to get only to project leader.
+    """
 
+    def has_permission(self, request, view) -> bool:
+        if request.user and request.user.id:
+            return True
+        return False
+
+    def has_object_permission(self, request, view, obj):
+        if obj.leader == request.user:
             return True
         return False
 
@@ -44,6 +59,5 @@ def has_object_permission(self, request, view, obj):
                 or obj.collaborator_set.filter(user=request.user).exists()
                 or obj.invite_set.filter(user=request.user).exists()
             ):
-
                 return True
             return False

projects/urls.py

@@ -9,6 +9,7 @@
     ProjectCollaborators,
     ProjectCountView,
     ProjectVacancyResponses,
+    ProjectRecommendedUsers,
 )
 
 app_name = "projects"
@@ -17,6 +18,7 @@
     path("", ProjectList.as_view()),
     path("<int:pk>/collaborators/", ProjectCollaborators.as_view()),
     path("<int:pk>/", ProjectDetail.as_view()),
+    path("<int:pk>/recommended_users", ProjectRecommendedUsers.as_view()),
     path("count/", ProjectCountView.as_view()),
     path("steps/", ProjectSteps.as_view()),
     path("achievements/", AchievementList.as_view()),

projects/views.py

@@ -1,3 +1,6 @@
+from random import sample
+
+from django.contrib.auth import get_user_model
 from django.db.models import Q
 from django_filters import rest_framework as filters
 from rest_framework import generics, permissions, status
@@ -7,11 +10,12 @@
 
 from core.permissions import IsStaffOrReadOnly
 from projects.filters import ProjectFilter
-from projects.helpers import VERBOSE_STEPS
+from projects.constants import VERBOSE_STEPS, RECOMMENDATIONS_COUNT
 from projects.models import Project, Achievement
 from projects.permissions import (
     IsProjectLeaderOrReadOnlyForNonDrafts,
     HasInvolvementInProjectOrReadOnly,
+    IsProjectLeader,
 )
 from projects.serializers import (
     ProjectDetailSerializer,
@@ -20,9 +24,12 @@
     AchievementDetailSerializer,
     ProjectCollaboratorSerializer,
 )
+from users.serializers import UserListSerializer
 from vacancy.models import VacancyResponse
 from vacancy.serializers import VacancyResponseListSerializer
 
+User = get_user_model()
+
 
 class ProjectList(generics.ListCreateAPIView):
     queryset = Project.objects.get_projects_for_list_view()
@@ -98,6 +105,34 @@ def put(self, request, pk, **kwargs):
         return super(ProjectDetail, self).put(request, pk)
 
 
+class ProjectRecommendedUsers(generics.RetrieveAPIView):
+    queryset = Project.objects.all()
+    permission_classes = [IsProjectLeader]
+    serializer_class = UserListSerializer
+
+    def get(self, request, pk, **kwargs):
+        project = self.get_object()
+        # fixme: store key_skills and required_skills more convenient, not just as a string'
+
+        all_needed_skills = set()
+        for vacancy in project.vacancies.all():
+            all_needed_skills.update(set(vacancy.required_skills.lower().split(",")))
+
+        recommended_users = []
+        for user in User.objects.get_members():
+            if user == request.user or not user.key_skills:
+                continue
+            skills = set(user.key_skills.lower().split(","))
+            if skills.intersection(all_needed_skills):
+                recommended_users.append(user)
+        sampled_recommended_users = sample(
+            recommended_users, min(RECOMMENDATIONS_COUNT, len(recommended_users))
+        )
+
+        serializer = self.get_serializer(sampled_recommended_users, many=True)
+        return Response(status=status.HTTP_200_OK, data=serializer.data)
+
+
 class ProjectCountView(generics.GenericAPIView):
     queryset = Project.objects.get_projects_for_count_view()
     serializer_class = ProjectListSerializer

users/managers.py

@@ -2,6 +2,8 @@
 from django.contrib.auth.models import UserManager
 from django.db.models import Manager
 
+from users.helpers import MEMBER
+
 
 class CustomUserManager(UserManager):
     def create_user(self, email, password=None, **extra_fields):
@@ -39,6 +41,9 @@ def get_users_for_detail_view(self):
             .all()
         )
 
+    def get_members(self):
+        return self.get_queryset().filter(user_type=MEMBER)
+
     def _create_user(self, email, password, **extra_fields):
         email = self.normalize_email(email)
         user = self.model(email=email, **extra_fields)