Skip to content

Commit 957c6c5

Browse files
committed
Упрощены workflow CI/CD, обновлён PR template и удалена интеграция ClickUp
1 parent 9ff44e5 commit 957c6c5

9 files changed

Lines changed: 47 additions & 178 deletions

File tree

.github/pull_request_template.md

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
1-
# Краткое название
1+
# Что изменено
22

3-
## Описание изменений
3+
Кратко опишите изменения и при необходимости приложите ссылку на задачу.
44

5-
_Опишите изменения, которые вы внесли в код. Не забывайте указывать номер задачи или ссылку на тикет._
5+
## Проверка
66

7+
Укажите, как проверялись изменения.
78

8-
## Тестирование
9+
- автоматические проверки
10+
- ручная проверка
11+
- шаги для воспроизведения
12+
- ожидаемый результат
913

10-
_Опишите, как тестировали свои изменения. Например, какие тесты проходят, а какие нет._
14+
## Риски и ограничения
1115

12-
## Проверка кода
16+
Укажите важные ограничения и возможные побочные эффекты.
1317

14-
_Опишите, как проверить ваш код._
15-
16-
## Дополнительная информация
17-
18-
_Здесь вы можете добавить какую-либо дополнительную информацию о своих изменениях._
18+
- миграции, изменения переменных окружения, feature flags
19+
- замечания по деплою
20+
- места, которые требуют повышенного внимания
Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,32 @@
1-
name: Django CI
1+
name: CI
22

33
on:
44
push:
55
branches:
6-
- '**'
6+
- "**"
77

88
jobs:
9-
django-test:
9+
lint:
10+
name: Lint
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v3
14+
15+
- name: Set up Python 3.11
16+
uses: actions/setup-python@v4
17+
with:
18+
python-version: 3.11
19+
20+
- name: Install lint dependencies
21+
run: |
22+
python -m pip install --upgrade pip
23+
pip install flake8
24+
25+
- name: Run flake8
26+
run: flake8 $(git ls-files '*.py')
27+
28+
test:
29+
name: Tests
1030
runs-on: ubuntu-latest
1131
steps:
1232
- uses: actions/checkout@v3
@@ -45,4 +65,4 @@ jobs:
4565
env:
4666
DEBUG: True
4767
DJANGO_SETTINGS_MODULE: procollab.settings
48-
PYTHONUNBUFFERED: 1
68+
PYTHONUNBUFFERED: 1

.github/workflows/dev-ci.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Deploy dev server'
1+
name: Deploy Dev
22

33
on:
44
push:
@@ -8,9 +8,10 @@ on:
88

99
jobs:
1010
deploy:
11+
name: Deploy
1112
runs-on: ubuntu-latest
1213
steps:
13-
- name: run on server
14+
- name: Deploy to server
1415
uses: garygrossgarten/github-action-ssh@release
1516
with:
1617
host: ${{ secrets.DEV_SERVER_HOST }}
@@ -41,9 +42,6 @@ jobs:
4142
echo "SELECTEL_CONTAINER_PASSWORD=${{ secrets.SELECTEL_CONTAINER_PASSWORD }}" >> .env &&
4243
echo "SELECTEL_CONTAINER_USERNAME=${{ secrets.SELECTEL_CONTAINER_USERNAME }}" >> .env &&
4344
44-
echo "CLICKUP_API_TOKEN=${{ secrets.CLICKUP_API_TOKEN }}" >> .env &&
45-
echo "CLICKUP_SPACE_ID=${{ secrets.CLICKUP_SPACE_ID }}" >> .env &&
46-
4745
echo "SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env &&
4846
4947
echo "UNISENDER_GO_API_KEY=${{ secrets.UNISENDER_GO_API_KEY }}" >> .env &&

.github/workflows/lints.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

.github/workflows/new_deploy.yml

Lines changed: 0 additions & 47 deletions
This file was deleted.

.github/workflows/release-ci.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: 'Build and Deploy server'
1+
name: Release Prod
22

33
on:
44
release:
@@ -7,7 +7,7 @@ on:
77

88
jobs:
99
test:
10-
name: 'Test before deploy'
10+
name: Tests
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: actions/checkout@v3
@@ -46,7 +46,7 @@ jobs:
4646
DEBUG: True
4747

4848
build:
49-
name: 'Build & Publish'
49+
name: Build Image
5050
runs-on: ubuntu-latest
5151
needs: [ test ]
5252
steps:
@@ -86,11 +86,12 @@ jobs:
8686
cache-to: type=gha,mode=max
8787
tags: ${{ steps.meta.outputs.tags }}
8888
labels: ${{ steps.meta.outputs.labels }}
89-
run:
89+
deploy:
90+
name: Deploy
9091
runs-on: ubuntu-latest
9192
needs: [ build ]
9293
steps:
93-
- name: run on server
94+
- name: Deploy to server
9495
uses: garygrossgarten/github-action-ssh@release
9596
with:
9697
host: ${{ secrets.SERVER_HOST }}
@@ -122,9 +123,6 @@ jobs:
122123
echo "SELECTEL_CONTAINER_PASSWORD=${{ secrets.SELECTEL_CONTAINER_PASSWORD }}" >> .env &&
123124
echo "SELECTEL_CONTAINER_USERNAME=${{ secrets.SELECTEL_CONTAINER_USERNAME }}" >> .env &&
124125
125-
echo "CLICKUP_API_TOKEN=${{ secrets.CLICKUP_API_TOKEN }}" >> .env &&
126-
echo "CLICKUP_SPACE_ID=${{ secrets.CLICKUP_SPACE_ID }}" >> .env &&
127-
128126
echo "SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env &&
129127
130128
echo "UNISENDER_GO_API_KEY=${{ secrets.UNISENDER_GO_API_KEY }}" >> .env &&

partner_programs/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def post(self, request, *args, **kwargs):
301301
"birthday": date_to_iso(data.get("birthday", "01-01-1900")),
302302
"is_active": True, # bypass email verification
303303
"onboarding_stage": None, # bypass onboarding
304-
"verification_date": timezone.now(), # bypass ClickUp verification
304+
"verification_date": timezone.now(), # bypass manual verification
305305
**{field_name: data.get(field_name, "") for field_name in user_fields},
306306
},
307307
)

users/services/verification.py

Lines changed: 0 additions & 64 deletions
This file was deleted.

users/views.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
VERBOSE_ROLE_TYPES,
4747
VERBOSE_USER_TYPES,
4848
VERIFY_EMAIL_REDIRECT_URL,
49-
OnboardingStage,
5049
)
5150
from users.helpers import check_related_fields_update, force_verify_user, verify_email
5251
from users.models import LikesOnProject, UserAchievement, UserSkillConfirmation
@@ -76,7 +75,6 @@
7675
from .pagination import UsersPagination
7776
from .schema import SKILL_PK_PARAM, USER_PK_PARAM
7877
from .services.cv_data_prepare import UserCVDataPreparerV2
79-
from .services.verification import VerificationTasks
8078
from .tasks import send_mail_cv
8179

8280
User = get_user_model()
@@ -493,13 +491,6 @@ def put(self, request: Request, pk):
493491
status=status.HTTP_400_BAD_REQUEST,
494492
data={"error": "Wrong onboarding stage number!"},
495493
)
496-
# if the user was on the last stage and passed it
497-
if (
498-
request.user.onboarding_stage == OnboardingStage.account_type.value
499-
and new_stage == OnboardingStage.completed.value
500-
):
501-
VerificationTasks.create(request.user)
502-
503494
request.user.onboarding_stage = new_stage
504495
request.user.save()
505496

0 commit comments

Comments
 (0)