fixed bug. also slightly optimized other signal

Author: sh1nkey

feed/signals.py

@@ -3,15 +3,24 @@
 from django.dispatch import receiver
 
 from news.models import News
-
+from projects.models import Project
 
 from vacancy.models import Vacancy
 
 
 @receiver(post_save, sender=Vacancy)
 def create_news_on_save(sender, instance, created, **kwargs):
     if created:
-        content_type = ContentType.objects.filter(model="vacancy").first()
+        content_type = ContentType.objects.get_for_model(Vacancy)
+        news_instance, created = News.objects.get_or_create(
+            content_type=content_type, object_id=instance.id
+        )
+
+
+@receiver(post_save, sender=Project)
+def create_news_on_created_project(sender, instance, created, **kwargs):
+    if not instance.draft:
+        content_type = ContentType.objects.get_for_model(Project)
         news_instance, created = News.objects.get_or_create(
             content_type=content_type, object_id=instance.id
         )

projects/models.py

@@ -2,14 +2,13 @@
 
 from django.contrib.auth import get_user_model
 from django.contrib.contenttypes.fields import GenericRelation
-from django.contrib.contenttypes.models import ContentType
 from django.db import models
 from django.db.models import UniqueConstraint
 
 from core.models import Like, View
 from files.models import UserFile
 from industries.models import Industry
-from news.models import News
+
 from projects.constants import VERBOSE_STEPS
 from projects.managers import AchievementManager, CollaboratorManager, ProjectManager
 from users.models import CustomUser
@@ -135,16 +134,6 @@ def get_collaborators_user_list(self) -> list[User]:
     def __str__(self):
         return f"Project<{self.id}> - {self.name}"
 
-    def save(
-        self, force_insert=False, force_update=False, using=None, update_fields=None
-    ):
-        if not self.draft:
-            content_type = ContentType.objects.filter(model="project").first()
-            news_instance, created = News.objects.get_or_create(
-                content_type=content_type, object_id=self.id
-            )
-        super().save(force_insert, force_update, using, update_fields)
-
     class Meta:
         ordering = ["-hidden_score", "-datetime_created"]
         verbose_name = "Проект"

projects/signals.py

@@ -12,9 +12,7 @@ def create_project(sender, instance, created, **kwargs):
     """
 
     if not instance.draft:
-        # if not a draft, check if project chat exists and if not create it
-        if not ProjectChat.objects.filter(project=instance).exists():
-            ProjectChat.objects.create(project=instance)
+        chat_instance, chat_created = ProjectChat.objects.get_or_create(project=instance)
 
     if created:
         Collaborator.objects.create(