AGAIN fixed fuck1ng user type objects creation

Author: yakser

users/admin.py

@@ -92,24 +92,24 @@ def save_model(self, request, obj, form, change):
             old_user = CustomUser.objects.get(id=obj.id)
             if obj.user_type != old_user.user_type:
                 try:
-                    if old_user.user_type == 1:
+                    if old_user.user_type == CustomUser.MEMBER:
                         old_user.member.delete()
-                    elif old_user.user_type == 2:
+                    elif old_user.user_type == CustomUser.MENTOR:
                         old_user.mentor.delete()
-                    elif old_user.user_type == 3:
+                    elif old_user.user_type == CustomUser.EXPERT:
                         old_user.expert.delete()
-                    elif old_user.user_type == 4:
+                    elif old_user.user_type == CustomUser.INVESTOR:
                         old_user.investor.delete()
                 except Exception:
                     pass
 
-                if obj.user_type == 1:
+                if obj.user_type == CustomUser.MEMBER:
                     Member.objects.create(user=old_user)
-                elif obj.user_type == 2:
+                elif obj.user_type == CustomUser.MENTOR:
                     Mentor.objects.create(user=old_user)
-                elif obj.user_type == 3:
+                elif obj.user_type == CustomUser.EXPERT:
                     Expert.objects.create(user=old_user)
-                elif obj.user_type == 4:
+                elif obj.user_type == CustomUser.INVESTOR:
                     Investor.objects.create(user=old_user)
 
         super().save_model(request, obj, form, change)

users/serializers.py

@@ -103,7 +103,12 @@ class Meta:
         ]
 
     def update(self, instance, validated_data):
+        IMMUTABLE_FIELDS = ("email", "is_active", "password")
+        USER_TYPE_FIELDS = ("member", "investor", "expert", "mentor")
+        RELATED_FIELDS = ("achievements",)
+
         if instance.user_type == CustomUser.MEMBER:
+            IMMUTABLE_FIELDS = ("email", "user_type", "is_active", "password")
             instance.member.__dict__.update(
                 validated_data.get("member", model_to_dict(instance.member))
             )
@@ -123,21 +128,45 @@ def update(self, instance, validated_data):
             instance.expert.preferred_industries = validated_data.get("expert", {}).get(
                 "preferred_industries", []
             )
-            print("expert", instance.expert.preferred_industries)
             instance.expert.save()
         elif instance.user_type == CustomUser.MENTOR:
             instance.mentor.__dict__.update(
                 validated_data.get("mentor", model_to_dict(instance.mentor))
             )
             instance.mentor.save()
 
-        IMMUTABLE_FIELDS = ("email", "user_type", "is_active", "password")
-        USER_TYPE_FIELDS = ("member", "investor", "expert", "mentor")
-        RELATED_FIELDS = ("achievements",)
+        user_types_to_attr = {
+            CustomUser.MEMBER: "member",
+            CustomUser.INVESTOR: "investor",
+            CustomUser.EXPERT: "expert",
+            CustomUser.MENTOR: "mentor",
+        }
+        user_types_to_model = {
+            CustomUser.MEMBER: Member,
+            CustomUser.INVESTOR: Investor,
+            CustomUser.EXPERT: Expert,
+            CustomUser.MENTOR: Mentor,
+        }
 
         for attr, value in validated_data.items():
             if attr in IMMUTABLE_FIELDS + USER_TYPE_FIELDS + RELATED_FIELDS:
                 continue
+            if attr == "user_type":
+                if value == instance.user_type or value not in user_types_to_attr.keys():
+                    continue
+                # we can't change user type to Member
+                if value == CustomUser.MEMBER:
+                    continue
+
+                # delete old user type object and attribute
+                getattr(instance, user_types_to_attr[instance.user_type]).delete()
+                setattr(instance, user_types_to_attr[instance.user_type], None)
+
+                instance.user_type = value
+
+                # create new user type object, attribute sets automatically
+                new_user_type = user_types_to_model[value](user=instance)
+                new_user_type.save()
             setattr(instance, attr, value)
 
         instance.save()

users/views.py

@@ -5,6 +5,7 @@
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.contrib.sites.shortcuts import get_current_site
+from django.db import transaction
 from django.db.models import Q
 from django.shortcuts import redirect
 from django.urls import reverse
@@ -108,6 +109,7 @@ class UserDetail(RetrieveUpdateDestroyAPIView):
     permission_classes = [IsOwnerOrReadOnly, IsAuthenticated]
     serializer_class = UserDetailSerializer
 
+    @transaction.atomic
     def put(self, request, pk):
         # bootleg version of updating achievements via user
         if request.data.get("achievements") is not None: