Skip to content

Commit c678956

Browse files
authored
Merge pull request #176 from PROCOLLAB-github/dev
Add news url to programs, fix NewsQuerysetMixin
2 parents a50191b + ad3eab0 commit c678956

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

news/mixins.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ def get_queryset_for_project(self):
1212
try:
1313
project = Project.objects.get(pk=self.kwargs.get("project_pk"))
1414
except Project.DoesNotExist:
15-
return []
15+
return News.objects.none()
1616
return News.objects.get_news(obj=project)
1717

1818
def get_queryset_for_program(self):
1919
try:
2020
program = PartnerProgram.objects.get(pk=self.kwargs.get("partnerprogram_pk"))
2121
except PartnerProgram.DoesNotExist:
22-
return []
22+
return News.objects.none()
2323
return News.objects.get_news(obj=program)
2424

2525
def get_queryset(self):
@@ -30,4 +30,4 @@ def get_queryset(self):
3030
# it's a partner program
3131
return self.get_queryset_for_program()
3232
else:
33-
return []
33+
return News.objects.none()

news/urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
from django.urls import path
22

33

4-
from news.views import NewsList
4+
from news.views import NewsList, NewsDetail
55

66
app_name = "news"
77

88
urlpatterns = [
99
path("", NewsList.as_view()),
10-
# path("<int:pk>/", NewsDetail.as_view()),
10+
path("<int:pk>/", NewsDetail.as_view()),
1111
]

partner_programs/urls.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from django.urls import path
22

3+
from news.views import NewsList, NewsDetail, NewsDetailSetViewed, NewsDetailSetLiked
34
from partner_programs.views import (
45
PartnerProgramList,
56
PartnerProgramDetail,
@@ -20,4 +21,12 @@
2021
path("<int:pk>/register_new/", PartnerProgramCreateUserAndRegister.as_view()),
2122
path("<int:pk>/set_liked/", PartnerProgramSetLiked.as_view()),
2223
path("<int:pk>/set_viewed/", PartnerProgramSetViewed.as_view()),
24+
path("<int:partnerprogram_pk>/news/", NewsList.as_view()),
25+
path("<int:partnerprogram_pk>/news/<int:pk>/", NewsDetail.as_view()),
26+
path(
27+
"<int:partnerprogram_pk>/news/<int:pk>/set_viewed/", NewsDetailSetViewed.as_view()
28+
),
29+
path(
30+
"<int:partnerprogram_pk>/news/<int:pk>/set_liked/", NewsDetailSetLiked.as_view()
31+
),
2332
]

0 commit comments

Comments
 (0)