Skip to content

Commit deb8903

Browse files
committed
Fixed custom list fields
1 parent ff52c7f commit deb8903

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

core/fields.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,7 @@
33

44
class CustomListField(serializers.ListField):
55
def to_representation(self, data):
6-
return [i.strip() for i in data.split(",")]
6+
return [value.strip() for value in data.split(",") if value.strip()]
7+
8+
def to_internal_value(self, data):
9+
return ",".join(data)

users/admin.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,13 @@ class CustomUserAdmin(admin.ModelAdmin):
6868
)
6969

7070
list_display = (
71+
"id",
7172
"email",
7273
"last_name",
7374
"first_name",
74-
"id",
7575
)
7676
list_display_links = (
77+
"id",
7778
"email",
7879
"first_name",
7980
"last_name",

vacancy/tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def setUp(self):
2222
self.user_project_owner = self.user_create()
2323
self.vacancy_create_data = {
2424
"role": "Test",
25-
"required_skills": "Test",
25+
"required_skills": ["Test"],
2626
"description": "Test",
2727
"is_active": True,
2828
"project": Project.objects.create(
@@ -41,7 +41,7 @@ def test_vacancy_creation(self):
4141

4242
self.assertEqual(response.status_code, 201)
4343
self.assertEqual(response.data["role"], "Test")
44-
self.assertEqual(response.data["required_skills"], "Test")
44+
self.assertEqual(response.data["required_skills"], ["Test"])
4545
self.assertEqual(response.data["description"], "Test")
4646
self.assertEqual(response.data["is_active"], True)
4747
self.assertEqual(response.data["project"], self.vacancy_create_data["project"])

0 commit comments

Comments
 (0)