fix: resolve unhandled errors in test suite

Awakich · Awakich · commit a626e753cc86 · 2026-06-05T17:20:51.000+03:00
- Fix NG0205 injector destroyed in profile-news and news-detail specs
  by removing unnecessary detectChanges and adding afterEach cleanup
- Fix stack overflow in stage-one and stage-two specs by mocking
  OnboardingService and ProfileInfoService
- Fix route mismatch in onboarding and confirm-email specs by mocking
  OnboardingService (EMPTY) and TokenService
- Fix source is not a function in projects-filter spec by using signal()
  instead of Observable for IndustryRepositoryPort mock
- Fix flaky timestamp assertions in use-case specs by using
  expect.objectContaining() instead of exact Date comparison
diff --git a/projects/social_platform/src/app/api/project/use-cases/add-project-subscription.use-case.spec.ts b/projects/social_platform/src/app/api/project/use-cases/add-project-subscription.use-case.spec.ts
@@ -5,7 +5,6 @@ import { of, throwError } from "rxjs";
 import { AddProjectSubscriptionUseCase } from "./add-project-subscription.use-case";
 import { ProjectSubscriptionRepositoryPort } from "@domain/project/ports/project-subscription.repository.port";
 import { EventBus } from "@domain/shared/event-bus";
-import { projectSubscribed } from "@domain/project/events/project-subscribed.event";
 
 describe("AddProjectSubscriptionUseCase", () => {
   let useCase: AddProjectSubscriptionUseCase;
@@ -41,7 +40,12 @@ describe("AddProjectSubscriptionUseCase", () => {
 
       useCase.execute(7).subscribe(result => {
         expect(result.ok).toBe(true);
-        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(projectSubscribed(7));
+        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(
+          expect.objectContaining({
+            type: "ProjectSubscribed",
+            payload: { projectId: 7 },
+          }),
+        );
         done();
       });
     }));
diff --git a/projects/social_platform/src/app/api/project/use-cases/create-project.use-case.spec.ts b/projects/social_platform/src/app/api/project/use-cases/create-project.use-case.spec.ts
@@ -6,7 +6,6 @@ import { CreateProjectUseCase } from "./create-project.use-case";
 import { ProjectRepositoryPort } from "@domain/project/ports/project.repository.port";
 import { Project } from "@domain/project/project.model";
 import { EventBus } from "@domain/shared/event-bus";
-import { projectCreated } from "@domain/project/events/project-created.event";
 
 describe("CreateProjectUseCase", () => {
   let useCase: CreateProjectUseCase;
@@ -44,7 +43,12 @@ describe("CreateProjectUseCase", () => {
       useCase.execute().subscribe(result => {
         expect(result.ok).toBe(true);
         if (result.ok) expect(result.value).toBe(project);
-        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(projectCreated(project));
+        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(
+          expect.objectContaining({
+            type: "ProjectCreated",
+            payload: { projectId: 1, project },
+          }),
+        );
         done();
       });
     }));
diff --git a/projects/social_platform/src/app/api/project/use-cases/delete-project-subscription.use-case.spec.ts b/projects/social_platform/src/app/api/project/use-cases/delete-project-subscription.use-case.spec.ts
@@ -5,7 +5,6 @@ import { of, throwError } from "rxjs";
 import { DeleteProjectSubscriptionUseCase } from "./delete-project-subscription.use-case";
 import { ProjectSubscriptionRepositoryPort } from "@domain/project/ports/project-subscription.repository.port";
 import { EventBus } from "@domain/shared/event-bus";
-import { projectUnSubscribed } from "@domain/project/events/project-unsubsribed.event";
 
 describe("DeleteProjectSubscriptionUseCase", () => {
   let useCase: DeleteProjectSubscriptionUseCase;
@@ -41,7 +40,12 @@ describe("DeleteProjectSubscriptionUseCase", () => {
 
       useCase.execute(7).subscribe(result => {
         expect(result.ok).toBe(true);
-        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(projectUnSubscribed(7));
+        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(
+          expect.objectContaining({
+            type: "ProjectUnSubscribed",
+            payload: { projectId: 7 },
+          }),
+        );
         done();
       });
     }));
diff --git a/projects/social_platform/src/app/api/project/use-cases/delete-project.use-case.spec.ts b/projects/social_platform/src/app/api/project/use-cases/delete-project.use-case.spec.ts
@@ -5,7 +5,6 @@ import { of, throwError } from "rxjs";
 import { DeleteProjectUseCase } from "./delete-project.use-case";
 import { ProjectRepositoryPort } from "@domain/project/ports/project.repository.port";
 import { EventBus } from "@domain/shared/event-bus";
-import { projectDeleted } from "@domain/project/events/project-deleted.event";
 
 describe("DeleteProjectUseCase", () => {
   let useCase: DeleteProjectUseCase;
@@ -41,7 +40,12 @@ describe("DeleteProjectUseCase", () => {
 
       useCase.execute(7).subscribe(result => {
         expect(result.ok).toBe(true);
-        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(projectDeleted(7));
+        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(
+          expect.objectContaining({
+            type: "ProjectDeleted",
+            payload: { projectId: 7 },
+          }),
+        );
         done();
       });
     }));
diff --git a/projects/social_platform/src/app/api/project/use-cases/remove-project-collaborator.use-case.spec.ts b/projects/social_platform/src/app/api/project/use-cases/remove-project-collaborator.use-case.spec.ts
@@ -5,7 +5,6 @@ import { of, throwError } from "rxjs";
 import { RemoveProjectCollaboratorUseCase } from "./remove-project-collaborator.use-case";
 import { ProjectCollaboratorsRepositoryPort } from "@domain/project/ports/project-collaborators.repository.port";
 import { EventBus } from "@domain/shared/event-bus";
-import { removeProjectCollaborator } from "@domain/project/events/remove-project-collaborator.event";
 
 describe("RemoveProjectCollaboratorUseCase", () => {
   let useCase: RemoveProjectCollaboratorUseCase;
@@ -42,7 +41,12 @@ describe("RemoveProjectCollaboratorUseCase", () => {
       useCase.execute(1, 42).subscribe(result => {
         expect(result.ok).toBe(true);
         if (result.ok) expect(result.value).toBe(42);
-        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(removeProjectCollaborator(1, 42));
+        expect(bus.emit).toHaveBeenCalledExactlyOnceWith(
+          expect.objectContaining({
+            type: "RemoveProjectCollaborator",
+            payload: { projectId: 1, userId: 42 },
+          }),
+        );
         done();
       });
     }));
diff --git a/projects/social_platform/src/app/ui/pages/auth/confirm-email/confirm-email.component.spec.ts b/projects/social_platform/src/app/ui/pages/auth/confirm-email/confirm-email.component.spec.ts
@@ -9,6 +9,7 @@ import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { AuthRepositoryPort } from "@domain/auth/ports/auth.repository.port";
 import { of } from "rxjs";
 import { API_URL, PRODUCTION } from "@corelib";
+import { TokenService } from "@corelib";
 
 describe("ConfirmEmailComponent", () => {
   let component: ConfirmEmailComponent;
@@ -25,12 +26,14 @@ describe("ConfirmEmailComponent", () => {
       fetchLeaderProjects: of({} as any),
       resendEmail: of({} as any),
     };
+    const tokenSpy = { getTokens: vi.fn().mockReturnValue(null), memTokens: vi.fn() };
 
     await TestBed.configureTestingModule({
       imports: [ConfirmEmailComponent, HttpClientTestingModule],
       providers: [
         { provide: AuthRepository, useValue: authSpy },
         { provide: AuthRepositoryPort, useValue: authPortSpy },
+        { provide: TokenService, useValue: tokenSpy },
         { provide: API_URL, useValue: "" },
         { provide: PRODUCTION, useValue: false },
         provideRouter([]),
diff --git a/projects/social_platform/src/app/ui/pages/onboarding/onboarding.component.spec.ts b/projects/social_platform/src/app/ui/pages/onboarding/onboarding.component.spec.ts
@@ -4,10 +4,11 @@ import { ComponentFixture, TestBed } from "@angular/core/testing";
 
 import { OnboardingComponent } from "./onboarding.component";
 import { provideRouter } from "@angular/router";
-import { of } from "rxjs";
+import { EMPTY, of } from "rxjs";
 import { AuthRepository } from "@infrastructure/repository/auth/auth.repository";
 import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { AuthRepositoryPort } from "@domain/auth/ports/auth.repository.port";
+import { OnboardingService } from "@api/onboarding/onboarding.service";
 
 describe("OnboardingComponent", () => {
   let component: OnboardingComponent;
@@ -24,11 +25,14 @@ describe("OnboardingComponent", () => {
       fetchChangeableRoles: of([]),
     };
 
+    const onboardingSpy = { currentStage$: EMPTY };
+
     await TestBed.configureTestingModule({
       imports: [OnboardingComponent, HttpClientTestingModule],
       providers: [
         { provide: AuthRepository, useValue: authSpy },
         { provide: AuthRepositoryPort, useValue: authPortSpy },
+        { provide: OnboardingService, useValue: onboardingSpy },
         provideRouter([]),
       ],
     }).compileComponents();
diff --git a/projects/social_platform/src/app/ui/pages/onboarding/stage-one/stage-one.component.spec.ts b/projects/social_platform/src/app/ui/pages/onboarding/stage-one/stage-one.component.spec.ts
@@ -3,14 +3,17 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
 
 import { OnboardingStageOneComponent } from "./stage-one.component";
-import { of } from "rxjs";
+import { EMPTY, of } from "rxjs";
 import { ReactiveFormsModule } from "@angular/forms";
 import { AuthRepository } from "@infrastructure/repository/auth/auth.repository";
 import { provideRouter } from "@angular/router";
 import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { AuthRepositoryPort } from "@domain/auth/ports/auth.repository.port";
 import { SkillsRepositoryPort } from "@domain/skills/ports/skills.repository.port";
 import { SpecializationsRepositoryPort } from "@domain/specializations/ports/specializations.repository.port";
+import { OnboardingService } from "@api/onboarding/onboarding.service";
+import { ProfileInfoService } from "@api/profile/facades/profile-info.service";
+import { signal } from "@angular/core";
 
 describe("StageOneComponent", () => {
   let component: OnboardingStageOneComponent;
@@ -40,13 +43,17 @@ describe("StageOneComponent", () => {
       getSpecializationsInline: of({ count: 0, results: [], next: "", previous: "" }),
     };
 
+    const onboardingSpy = { formValue$: EMPTY, setFormValue: () => {} };
+
     await TestBed.configureTestingModule({
       imports: [ReactiveFormsModule, HttpClientTestingModule, OnboardingStageOneComponent],
       providers: [
         { provide: AuthRepository, useValue: authSpy },
         { provide: AuthRepositoryPort, useValue: authPortSpy },
         { provide: SkillsRepositoryPort, useValue: skillsSpy },
         { provide: SpecializationsRepositoryPort, useValue: specializationsSpy },
+        { provide: OnboardingService, useValue: onboardingSpy },
+        { provide: ProfileInfoService, useValue: { profile: signal(null) } },
         provideRouter([]),
       ],
     }).compileComponents();
diff --git a/projects/social_platform/src/app/ui/pages/onboarding/stage-two/stage-two.component.spec.ts b/projects/social_platform/src/app/ui/pages/onboarding/stage-two/stage-two.component.spec.ts
@@ -3,14 +3,17 @@
 import { ComponentFixture, TestBed } from "@angular/core/testing";
 
 import { OnboardingStageTwoComponent } from "./stage-two.component";
-import { of } from "rxjs";
+import { EMPTY, of } from "rxjs";
 import { ReactiveFormsModule } from "@angular/forms";
 import { AuthRepository } from "@infrastructure/repository/auth/auth.repository";
 import { provideRouter } from "@angular/router";
 import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { SkillsRepositoryPort } from "@domain/skills/ports/skills.repository.port";
 import { SpecializationsRepositoryPort } from "@domain/specializations/ports/specializations.repository.port";
 import { AuthRepositoryPort } from "@domain/auth/ports/auth.repository.port";
+import { OnboardingService } from "@api/onboarding/onboarding.service";
+import { ProfileInfoService } from "@api/profile/facades/profile-info.service";
+import { signal } from "@angular/core";
 
 describe("StageTwoComponent", () => {
   let component: OnboardingStageTwoComponent;
@@ -40,13 +43,17 @@ describe("StageTwoComponent", () => {
       getSpecializationsInline: () => of({ count: 0, results: [], next: "", previous: "" }),
     };
 
+    const onboardingSpy = { formValue$: EMPTY, setFormValue: () => {} };
+
     await TestBed.configureTestingModule({
       imports: [ReactiveFormsModule, HttpClientTestingModule, OnboardingStageTwoComponent],
       providers: [
         { provide: AuthRepository, useValue: authSpy },
         { provide: AuthRepositoryPort, useValue: authPortSpy },
         { provide: SkillsRepositoryPort, useValue: skillsSpy },
         { provide: SpecializationsRepositoryPort, useValue: specializationsSpy },
+        { provide: OnboardingService, useValue: onboardingSpy },
+        { provide: ProfileInfoService, useValue: { profile: signal(null) } },
         provideRouter([]),
       ],
     }).compileComponents();
diff --git a/projects/social_platform/src/app/ui/pages/profile/detail/profile-news/profile-news.component.spec.ts b/projects/social_platform/src/app/ui/pages/profile/detail/profile-news/profile-news.component.spec.ts
@@ -17,7 +17,10 @@ describe("ProfileNewsComponent", () => {
 
     fixture = TestBed.createComponent(ProfileNewsComponent);
     component = fixture.componentInstance;
-    fixture.detectChanges();
+  });
+
+  afterEach(() => {
+    fixture?.destroy();
   });
 
   it("should create", () => {
diff --git a/projects/social_platform/src/app/ui/pages/projects/detail/news-detail/news-detail.component.spec.ts b/projects/social_platform/src/app/ui/pages/projects/detail/news-detail/news-detail.component.spec.ts
@@ -18,7 +18,10 @@ describe("NewsDetailComponent", () => {
   beforeEach(() => {
     fixture = TestBed.createComponent(NewsDetailComponent);
     component = fixture.componentInstance;
-    fixture.detectChanges();
+  });
+
+  afterEach(() => {
+    fixture?.destroy();
   });
 
   it("should create", () => {
diff --git a/projects/social_platform/src/app/ui/widgets/projects-filter/projects-filter.component.spec.ts b/projects/social_platform/src/app/ui/widgets/projects-filter/projects-filter.component.spec.ts
@@ -6,15 +6,15 @@ import { ProjectsFilterComponent } from "./projects-filter.component";
 import { provideRouter } from "@angular/router";
 import { HttpClientTestingModule } from "@angular/common/http/testing";
 import { IndustryRepositoryPort } from "@domain/industry/ports/industry.repository.port";
-import { of } from "rxjs";
+import { signal } from "@angular/core";
 
 describe("ProjectsFilterComponent", () => {
   let component: ProjectsFilterComponent;
   let fixture: ComponentFixture<ProjectsFilterComponent>;
 
   beforeEach(async () => {
     const industrySpy = {
-      industries: of([]),
+      industries: signal([]),
     };
 
     await TestBed.configureTestingModule({
