fix: bump snap rust-deps toolchain to match MSRV#5771
Open
Conversation
The snapcraft.yaml rust-deps stanza pinned Rust 1.69.0, but the workspace MSRV is 1.75.0. Recent releases still succeed because the prqlc part uses plugin: rust with build-packages: [cargo], which relies on the debian cargo rather than the rustup install from rust-deps — so the pin has been effectively dead code. Updating it to 1.75.0 keeps it consistent with the rest of the repo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
rust-depspart inprqlc/packages/snap/snapcraft.yamlpinned Rust 1.69.0 via rustup, but the workspace MSRV (in the rootCargo.toml) is 1.75.0. Recent snap release builds have been succeeding because theprqlcpart usesplugin: rustwithbuild-packages: [cargo], which relies on the debian cargo rather than the rustup install fromrust-deps— so the 1.69.0 pin has effectively been dead code. This bumps it to 1.75.0 so it's consistent with the rest of the repo and won't mislead anyone who reads the file.Found during the nightly rolling survey of
prqlc/packages/snap/snapcraft.yaml. An arguably cleaner fix would be to remove therust-depsstanza entirely, but I can't fully verify that without producing a release build, so this change is the safer minimum.Test plan
build-and-publish-snapjob inrelease.yamlonly runs onreleaseevents, so it's not exercised by PR CI)