Merge pull request #430 from richjenks/recipe-selector-roi

Fix recipe selector ROI column sorting

Author: jplacht

src/features/planning/components/PlanProductionRecipe.vue

@@ -105,6 +105,13 @@
 	);
 
 	const cogmWithCX = computed(() => !!props.cxUuid);
+
+	function roiSorter(
+		row1: Record<string, unknown>,
+		row2: Record<string, unknown>
+	): number {
+		return (row1.dailyRevenue as number) - (row2.dailyRevenue as number);
+	}
 </script>
 
 <template>
@@ -255,15 +262,15 @@
 						</span>
 					</template>
 				</XNDataTableColumn>
-				<XNDataTableColumn key="roi" title="ROI" sorter="default">
+				<XNDataTableColumn key="roi" title="ROI" :sorter="roiSorter">
 					<template #render-cell="{ rowData }">
 						<span
 							:class="
 								rowData.roi >= 0
 									? 'text-positive!'
 									: 'text-negative!'
 							">
-							{{ formatNumber(rowData.roi) }} d
+							{{ rowData.roi < 0 ? "—" : formatNumber(rowData.roi) + " d" }}
 						</span>
 					</template>
 				</XNDataTableColumn>