Add soi_iitax parameter#3072
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3072 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 2721 2721
=========================================
Hits 2721 2721
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jdebacker
reviewed
May 27, 2026
jdebacker
reviewed
May 27, 2026
Member
jdebacker
left a comment
There was a problem hiding this comment.
Very nice PR. I like how you created the boolean to allow modeling of the IRS/SOI concept and traditional revenue estimates.
I have just one question on some files that are removed. When I'm clear on those changes, I'll merge.
Member
|
Ah - those files being removed are just clean up of the repo. Thanks! Merging, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3071 by adding a new parameter called
soi_iitaxthat controlsthe categorization of the self-employment tax (
setax) and theadditional Medicare tax (
ptax_amc) as being part of the income taxor as being part of the payroll tax.
It is important that Tax-Calculator have this flexibility because
grouping
setaxandptax_amcas being part of the income tax(
soi_iitax==true) reflects the structure of IRS tax forms andcorresponds to SOI statistics used to construct the TMD input data files.
But categorizing
setaxandptax_amcas being payroll taxes(
soi_iitax==false) is the tax-analysis approach used by all federaltax agencies.
This pull request sets the value of
soi_iitaxto false in all yearsso that Tax-Calculator produces conventional tax-analysis results by
default. Note that this is a change from the way Tax-Calculator has
worked since its beginnings. Concurrently, the code in the TMD
repository has been revised so that the value of
soi_iitaxis trueand Tax-Calculator produces SOI-compatible income tax statistics.
Also, a test has been added to the
test_reforms.pymodule to confirmthat the new
soi_iitaxlogic produces the correct results describedin issue #3071 for a reform that eliminates the cap on FICA and SECA
taxable earnings.
How does PolicyEngine-US handle this issue?
The following prompt:
❯ Looking at the code in the GitHub PolicyEngine-US repository, does that model
include the SECA tax (that is, the self-employment social security tax) in
the income tax total or in the payroll tax total?
produced this Claude Code response:
⏺ Let me look at the PolicyEngine-US repository to find how SECA tax is
categorized.
⏺ Explore(Find SECA tax categorization in PolicyEngine-US)
⎿ Done (64 tool uses · 58.6k tokens · 4m 59s)
(ctrl+o to expand)
⏺ In PolicyEngine-US, SECA tax is in neither — it's kept as its own separate tax
category.
The model has three distinct tax buckets under
/policyengine_us/variables/gov/irs/tax/:
credits. Does not include SECA.
Medicare tax, employee state payroll tax. Does not include SECA.
self_employment_medicare_tax. Stands alone.
So self_employment_tax is a person-level variable summing the SE Social
Security and SE Medicare components, computed independently from both income
tax and employee payroll tax totals.