🪲 [Fix]: Resolve PSScriptAnalyzer findings in examples and tests

- Drop the unused child-page variable in the Pages example

- Splat Connect-Confluence in the integration test to stay within the line-length limit

- Suppress PSAvoidUsingConvertToSecureStringWithPlainText (the API token is a CI environment secret)

Author: MariusStorhaug

examples/Pages.ps1

@@ -22,7 +22,7 @@ Get-ConfluencePage -PageId $page.id
 Set-ConfluencePage -PageId $page.id -Body '<p>Updated content</p>'
 
 # Add a child page, then list children and descendants
-$child = New-ConfluencePage -SpaceId $space.id -Title 'Details' -ParentId $page.id -Body '<p>Nested</p>'
+New-ConfluencePage -SpaceId $space.id -Title 'Details' -ParentId $page.id -Body '<p>Nested</p>'
 Get-ConfluencePageChild -PageId $page.id
 Get-ConfluenceDescendant -PageId $page.id
 

tests/Confluence.Tests.ps1

@@ -1,5 +1,7 @@
 [Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '',
     Justification = 'Pester test cases assign variables that are used in other scopes.')]
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingConvertToSecureStringWithPlainText', '',
+    Justification = 'The API token is supplied as a CI environment secret and must be converted to a SecureString for Connect-Confluence.')]
 [CmdletBinding()]
 param()
 
@@ -70,7 +72,14 @@ Describe 'Confluence' {
     Context 'Integration' -Skip:([string]::IsNullOrEmpty($env:CONFLUENCE_API_TOKEN)) {
         BeforeAll {
             $secureToken = ConvertTo-SecureString -String $env:CONFLUENCE_API_TOKEN -AsPlainText -Force
-            Connect-Confluence -ApiBaseUri $env:CONFLUENCE_API_BASE_URI -Username $env:CONFLUENCE_USERNAME -Token $secureToken -SpaceKey $env:CONFLUENCE_SPACE_KEY -Name 'ci'
+            $connectParams = @{
+                ApiBaseUri = $env:CONFLUENCE_API_BASE_URI
+                Username   = $env:CONFLUENCE_USERNAME
+                Token      = $secureToken
+                SpaceKey   = $env:CONFLUENCE_SPACE_KEY
+                Name       = 'ci'
+            }
+            Connect-Confluence @connectParams
         }
 
         AfterAll {