🩹 [Patch]: Harden site URI parsing, surface site-info probe errors, avoid redundant config writes

Author: MariusStorhaug

src/functions/private/Config/Initialize-ConfluenceConfig.ps1

@@ -29,18 +29,29 @@
         }
     }
 
+    $dirty = $false
     if ($Force -or -not $stored) {
         $config = ConvertTo-ConfluenceHashtable -InputObject $script:Confluence.DefaultConfig
+        $dirty = $true
     } else {
         $config = ConvertTo-ConfluenceHashtable -InputObject $stored
         foreach ($key in $script:Confluence.DefaultConfig.Keys) {
             if (-not $config.ContainsKey($key)) {
                 $config[$key] = $script:Confluence.DefaultConfig[$key]
+                $dirty = $true
             }
         }
     }
 
-    $config['ID'] = $id
-    $null = Set-Context -ID $id -Context $config -Vault $vault
+    if ($config['ID'] -ne $id) {
+        $config['ID'] = $id
+        $dirty = $true
+    }
+
+    # Only persist when we actually created or changed the stored config, to avoid
+    # unnecessary vault writes on every cmdlet call (this runs from most cmdlets).
+    if ($dirty) {
+        $null = Set-Context -ID $id -Context $config -Vault $vault
+    }
     $script:Confluence.Config = $config
 }

src/functions/public/Site/Get-ConfluenceCloudId.ps1

@@ -58,12 +58,16 @@ function Get-ConfluenceCloudId {
         }
 
         # Derive the host whether the caller passed a bare subdomain, a host, or a URL.
-        $siteHost = if ($trimmed -match '^[A-Za-z][A-Za-z0-9+.-]*://') {
-            ([uri]$trimmed).Host
-        } elseif ($trimmed -match '[/.]') {
-            ([uri]"https://$trimmed").Host
-        } else {
-            "$trimmed.atlassian.net"
+        try {
+            $siteHost = if ($trimmed -match '^[A-Za-z][A-Za-z0-9+.-]*://') {
+                ([uri]$trimmed).Host
+            } elseif ($trimmed -match '[/.]') {
+                ([uri]"https://$trimmed").Host
+            } else {
+                "$trimmed.atlassian.net"
+            }
+        } catch {
+            throw "Could not determine the site host from '$Site': $($_.Exception.Message)"
         }
 
         if ([string]::IsNullOrWhiteSpace($siteHost)) {

src/functions/public/Site/Get-ConfluenceSiteInfo.ps1

@@ -36,6 +36,7 @@ function Get-ConfluenceSiteInfo {
     # _links.base (the browsable site URL) appears on any v2 collection response;
     # try a couple so this works whether the token has read:space or only read:page.
     $siteUrl = $null
+    $lastError = $null
     foreach ($probe in '/wiki/api/v2/spaces', '/wiki/api/v2/pages') {
         try {
             $response = Invoke-ConfluenceRestMethod -ApiEndpoint $probe -Query @{ limit = 1 } -Context $Context
@@ -44,9 +45,13 @@ function Get-ConfluenceSiteInfo {
                 break
             }
         } catch {
+            $lastError = $_
             continue
         }
     }
+    if (-not $siteUrl -and $lastError) {
+        Write-Verbose "Could not resolve the browsable site URL from the probe endpoints: $($lastError.Exception.Message)"
+    }
 
     [pscustomobject]@{
         CloudId    = $cloudId