Harden context lookup and WhatIf behavior

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: MariusStorhaug

src/functions/private/Auth/Set-DomeneshopDefaultContext.ps1

@@ -40,8 +40,8 @@ function Set-DomeneshopDefaultContext {
     )
 
     $config = Get-DomeneshopConfig
-    $config.DefaultContext = $Context
     if ($PSCmdlet.ShouldProcess('Domeneshop module configuration', "Set [$Context] as the default context")) {
+        $config.DefaultContext = $Context
         $null = Set-Context -ID '__Domeneshop.Config' -Vault 'Domeneshop' -Context $config
     }
 }

src/functions/public/Auth/Get-DomeneshopContext.ps1

@@ -63,5 +63,13 @@ function Get-DomeneshopContext {
         $id = $config.DefaultContext
     }
 
-    Get-Context -ID $id -Vault 'Domeneshop' | Where-Object { $_.ID -ne '__Domeneshop.Config' } | Sort-Object -Property ID
+    $contexts = @(
+        Get-Context -ID $id -Vault 'Domeneshop' |
+            Where-Object { $_.ID -ne '__Domeneshop.Config' }
+    )
+    if (-not $ListAvailable -and $contexts.Count -eq 0) {
+        throw "Domeneshop context [$id] was not found in the Domeneshop vault."
+    }
+
+    $contexts | Sort-Object -Property ID
 }

tests/Domeneshop.Private.Tests.ps1

@@ -48,6 +48,17 @@ Describe 'Domeneshop private helpers' {
             Should -Throw '*reserved for Domeneshop module configuration*'
     }
 
+    It 'does not mutate the configuration when setting the default with WhatIf' {
+        $config = [pscustomobject]@{ DefaultContext = 'original' }
+        Mock Get-DomeneshopConfig { $config }
+        Mock Set-Context {}
+
+        Set-DomeneshopDefaultContext -Context 'replacement' -WhatIf
+
+        $config.DefaultContext | Should -Be 'original'
+        Should -Invoke Set-Context -Times 0 -Exactly
+    }
+
     It 'uses basic authentication and terminating transport errors' {
         Mock Invoke-RestMethod { [pscustomobject]@{ ok = $true } }
 

tests/Get-DomeneshopContext.Tests.ps1

@@ -39,6 +39,21 @@ Describe 'Get-DomeneshopContext' {
             Should -Throw '*reserved for Domeneshop module configuration*'
     }
 
+    It 'throws when the configured default context is missing from the vault' {
+        Mock Get-DomeneshopConfig { [pscustomobject]@{ DefaultContext = 'missing' } }
+        Mock Get-Context {}
+
+        { Get-DomeneshopContext } |
+            Should -Throw '*Domeneshop context*missing*was not found in the Domeneshop vault*'
+    }
+
+    It 'throws when an explicitly requested context is missing from the vault' {
+        Mock Get-Context {}
+
+        { Get-DomeneshopContext -Context 'missing' } |
+            Should -Throw '*Domeneshop context*missing*was not found in the Domeneshop vault*'
+    }
+
     It 'excludes the module configuration when listing contexts' {
         Mock Get-Context {
             @(