Reject whitespace-only command inputs

Cover API tokens, DDNS parameters, DNS filters, forward hosts, and smoke-test names at the parameter boundary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: MariusStorhaug

src/functions/public/Auth/Connect-DomeneshopAccount.ps1

@@ -49,6 +49,7 @@ function Connect-DomeneshopAccount {
         # The Domeneshop API token used as the Basic authentication username.
         [Parameter(Mandatory)]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [string] $Token,
 
         # The Domeneshop API secret as a string or secure string.

src/functions/public/Ddns/Update-DomeneshopDdns.ps1

@@ -40,12 +40,14 @@ function Update-DomeneshopDdns {
         # The fully qualified hostname to update.
         [Parameter(Mandatory)]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [Alias('Host')]
         [string] $Hostname,
 
         # The IPv4 or IPv6 address to publish.
         [Parameter()]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [Alias('IP')]
         [string] $MyIP,
 

src/functions/public/Dns/Get-DomeneshopDnsRecord.ps1

@@ -51,17 +51,20 @@ function Get-DomeneshopDnsRecord {
         # A hostname filter for list requests.
         [Parameter(ParameterSetName = 'List')]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [Alias('Host')]
         [string] $RecordHost,
 
         # A DNS record type filter for list requests.
         [Parameter(ParameterSetName = 'List')]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [string] $Type,
 
         # A record-data filter for list requests.
         [Parameter(ParameterSetName = 'List')]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [string] $Data,
 
         # The stored credential context to use instead of the default.

src/functions/public/Forwards/Get-DomeneshopForward.ps1

@@ -46,6 +46,7 @@ function Get-DomeneshopForward {
         # The hostname of a specific HTTP forward.
         [Parameter(Mandatory, ParameterSetName = 'Get by host')]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [Alias('Host')]
         [string] $ForwardHost,
 

src/functions/public/Forwards/Remove-DomeneshopForward.ps1

@@ -41,6 +41,7 @@ function Remove-DomeneshopForward {
         # The hostname of the HTTP forward to remove.
         [Parameter(Mandatory)]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [Alias('Host')]
         [string] $ForwardHost,
 

src/functions/public/Forwards/Set-DomeneshopForward.ps1

@@ -45,6 +45,7 @@ function Set-DomeneshopForward {
         # The hostname of the HTTP forward to update.
         [Parameter(Mandatory)]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [Alias('Host')]
         [string] $ForwardHost,
 

src/functions/public/Get-PSModuleTest.ps1

@@ -36,6 +36,7 @@
         # The name to include in the greeting.
         [Parameter(Mandatory)]
         [ValidateNotNullOrEmpty()]
+        [ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
         [string] $Name
     )
 

tests/Connect-DomeneshopAccount.Tests.ps1

@@ -109,4 +109,10 @@ Describe 'Connect-DomeneshopAccount' {
 
         Should -Invoke Set-Context -Times 0 -Exactly
     }
+
+    It 'rejects a whitespace-only API token' {
+        { Connect-DomeneshopAccount -Token ' ' -Secret 'secret' -Context 'demo' } | Should -Throw
+
+        Should -Invoke Set-Context -Times 0 -Exactly
+    }
 }

tests/Get-DomeneshopDnsRecord.Tests.ps1

@@ -38,4 +38,12 @@ Describe 'Get-DomeneshopDnsRecord' {
             $Uri -eq 'https://api.domeneshop.no/v0/domains/42/dns/7'
         }
     }
+
+    It 'rejects whitespace-only list filters' {
+        { Get-DomeneshopDnsRecord -Context 'demo' -DomainID 42 -RecordHost ' ' } | Should -Throw
+        { Get-DomeneshopDnsRecord -Context 'demo' -DomainID 42 -Type ' ' } | Should -Throw
+        { Get-DomeneshopDnsRecord -Context 'demo' -DomainID 42 -Data ' ' } | Should -Throw
+
+        Should -Invoke Invoke-DomeneshopApiRequest -Times 0 -Exactly
+    }
 }

tests/Get-DomeneshopForward.Tests.ps1

@@ -38,4 +38,10 @@ Describe 'Get-DomeneshopForward' {
             $Uri -eq 'https://api.domeneshop.no/v0/domains/42/forwards/home%20office'
         }
     }
+
+    It 'rejects whitespace-only forward hosts' {
+        { Get-DomeneshopForward -Context 'demo' -DomainID 42 -ForwardHost ' ' } | Should -Throw
+
+        Should -Invoke Invoke-DomeneshopApiRequest -Times 0 -Exactly
+    }
 }