Skip to content

Commit 322329f

Browse files
Fix review feedback: run-scoped team names, lowercase license keyword, correct README cleanup patterns
1 parent 36c0e05 commit 322329f

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

tests/BeforeAll.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ LogGroup 'BeforeAll - Global Test Setup' {
4949
$repoParams = @{
5050
Name = $repoName
5151
AddReadme = $true
52-
License = 'MIT'
52+
License = 'mit'
5353
Gitignore = 'VisualStudio'
5454
}
5555
switch ($OwnerType) {

tests/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ For generic guidance on setup/teardown scripts, see the
7272
Runs once before all parallel test files. For each auth case (except `GITHUB_TOKEN`):
7373

7474
1. Connects using the auth case credentials
75-
2. Cleans up stale repos from previous failed runs (matching `Test-$os-$TokenType-*`)
75+
2. Cleans up stale repos from previous failed runs (matching `Test-{OS}-{TokenType}-{RunID}*`)
7676
3. Creates a primary shared repository per OS: `Test-{OS}-{TokenType}-{GITHUB_RUN_ID}`
7777
- Includes `AddReadme`, `License` (MIT), and `Gitignore` (VisualStudio) for release tests
7878
- For `user` owners: `New-GitHubRepository -Name $repoName`
@@ -84,7 +84,7 @@ Runs once before all parallel test files. For each auth case (except `GITHUB_TOK
8484
Runs once after all parallel test files complete. For each auth case (except `GITHUB_TOKEN`):
8585

8686
1. Connects using the auth case credentials
87-
2. Removes all repositories matching the `Test-{OS}-{TokenType}-*` prefix
87+
2. Removes all repositories matching the `Test-{OS}-{TokenType}-{RunID}*` pattern (run-scoped)
8888

8989
## Test file pattern
9090

tests/Teams.Tests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ Describe 'Teams' {
4040
Write-Host ($context | Format-List | Out-String)
4141
}
4242
}
43-
$teamPrefix = "$testName`_$os`_$TokenType"
44-
$teamName = "$teamPrefix`_$id"
43+
$teamPrefix = "$testName`_$os`_$TokenType`_$id"
44+
$teamName = $teamPrefix
4545

4646
switch ($OwnerType) {
4747
'organization' {

0 commit comments

Comments
 (0)