Retry Install-GitHubApp on enterprise organization to absorb propagation delay (#596)

Author: MariusStorhaug

tests/Organizations.Tests.ps1

@@ -143,7 +143,24 @@ Describe 'Organizations' {
         }
 
         It 'Install-GitHubApp - Installs a GitHub App to an organization' -Skip:($OwnerType -ne 'enterprise') {
-            $installation = Install-GitHubApp -Enterprise $owner -Organization $orgName -ClientID $installationContext.ClientID -RepositorySelection 'all'
+            # The enterprise organization was just created and may not have propagated to the
+            # enterprise apps endpoint yet. Retry briefly to absorb propagation delay before
+            # failing — GitHub returns 404 (rather than 403) when the resource is not yet visible
+            # to the token, which is indistinguishable from a missing-permission failure on the
+            # first call. See issue #596.
+            $installation = $null
+            $maxAttempts = 5
+            $delaySeconds = 3
+            for ($attempt = 1; $attempt -le $maxAttempts; $attempt++) {
+                try {
+                    $installation = Install-GitHubApp -Enterprise $owner -Organization $orgName -ClientID $installationContext.ClientID -RepositorySelection 'all'
+                    break
+                } catch {
+                    if ($attempt -eq $maxAttempts) { throw }
+                    Write-Host "Install-GitHubApp attempt $attempt failed ($($_.Exception.Message)); retrying in $delaySeconds seconds..."
+                    Start-Sleep -Seconds $delaySeconds
+                }
+            }
             LogGroup 'Installed App' {
                 Write-Host ($installation | Select-Object * | Out-String)
             }