🩹 [Patch]: Refactor variable names for clarity in Get-AggregatedStatus tests and improve settings file path handling in Invoke-ScriptAnalyzer

Author: MariusStorhaug

scripts/main.ps1

@@ -7,7 +7,8 @@ $codePath = Resolve-Path -Path $path | Select-Object -ExpandProperty Path
 $settingsFilePath = $null
 if (-not [string]::IsNullOrEmpty($env:PSMODULE_INVOKE_SCRIPTANALYZER_INPUT_SettingsFilePath)) {
     try {
-        $settingsFilePath = Resolve-Path -Path $env:PSMODULE_INVOKE_SCRIPTANALYZER_INPUT_SettingsFilePath -ErrorAction Stop | Select-Object -ExpandProperty Path
+        $settingsFilePath = Resolve-Path -Path $env:PSMODULE_INVOKE_SCRIPTANALYZER_INPUT_SettingsFilePath -ErrorAction Stop |
+            Select-Object -ExpandProperty Path
         Write-Information "Using settings file: $settingsFilePath"
     } catch {
         Write-Warning "Settings file not found at path: $($env:PSMODULE_INVOKE_SCRIPTANALYZER_INPUT_SettingsFilePath). Using default settings."

tests/Get-AggregatedStatus.ps1

@@ -20,25 +20,25 @@
 }
 
 # Build an array of objects for each job
-$ActionTestSrcSourceCodeExpectedOutcome = 'success'
-$ActionTestSrcSourceCodeOutcomeResult = $env:ActionTestSrcSourceCodeOutcome -eq $ActionTestSrcSourceCodeExpectedOutcome
-$ActionTestSrcSourceCodeExpectedConclusion = 'success'
-$ActionTestSrcSourceCodeConclusionResult = $env:ActionTestSrcSourceCodeConclusion -eq $ActionTestSrcSourceCodeExpectedConclusion
+$SourceCodeExpectedOutcome = 'success'
+$SourceCodeOutcomeResult = $env:SourceCodeOutcome -eq $SourceCodeExpectedOutcome
+$SourceCodeExpectedConclusion = 'success'
+$SourceCodeConclusionResult = $env:SourceCodeConclusion -eq $SourceCodeExpectedConclusion
 
-$ActionTestSrcCustomExpectedOutcome = 'success'
-$ActionTestSrcCustomOutcomeResult = $env:ActionTestSrcCustomOutcome -eq $ActionTestSrcCustomExpectedOutcome
-$ActionTestSrcCustomExpectedConclusion = 'success'
-$ActionTestSrcCustomConclusionResult = $env:ActionTestSrcCustomConclusion -eq $ActionTestSrcCustomExpectedConclusion
+$CustomExpectedOutcome = 'success'
+$CustomOutcomeResult = $env:CustomOutcome -eq $CustomExpectedOutcome
+$CustomExpectedConclusion = 'success'
+$CustomConclusionResult = $env:CustomConclusion -eq $CustomExpectedConclusion
 
-$ActionTestSrcWithManifestExpectedOutcome = 'failure'
-$ActionTestSrcWithManifestOutcomeResult = $env:ActionTestSrcWithManifestOutcome -eq $ActionTestSrcWithManifestExpectedOutcome
-$ActionTestSrcWithManifestExpectedConclusion = 'success'
-$ActionTestSrcWithManifestConclusionResult = $env:ActionTestSrcWithManifestConclusion -eq $ActionTestSrcWithManifestExpectedConclusion
+$WithManifestExpectedOutcome = 'failure'
+$WithManifestOutcomeResult = $env:WithManifestOutcome -eq $WithManifestExpectedOutcome
+$WithManifestExpectedConclusion = 'success'
+$WithManifestConclusionResult = $env:WithManifestConclusion -eq $WithManifestExpectedConclusion
 
-$ActionTestSrcWithManifestDefaultExpectedOutcome = 'failure'
-$ActionTestSrcWithManifestDefaultOutcomeResult = $env:ActionTestSrcWithManifestDefaultOutcome -eq $ActionTestSrcWithManifestDefaultExpectedOutcome
-$ActionTestSrcWithManifestDefaultExpectedConclusion = 'success'
-$ActionTestSrcWithManifestDefaultConclusionResult = $env:ActionTestSrcWithManifestDefaultConclusion -eq $ActionTestSrcWithManifestDefaultExpectedConclusion
+$WithManifestDefaultExpectedOutcome = 'failure'
+$WithManifestDefaultOutcomeResult = $env:WithManifestDefaultOutcome -eq $WithManifestDefaultExpectedOutcome
+$WithManifestDefaultExpectedConclusion = 'success'
+$WithManifestDefaultConclusionResult = $env:WithManifestDefaultConclusion -eq $WithManifestDefaultExpectedConclusion
 
 $ActionTestOutputsExpectedOutcome = 'success'
 $ActionTestOutputsOutcomeResult = $env:ActionTestOutputsOutcome -eq $ActionTestOutputsExpectedOutcome
@@ -48,39 +48,39 @@ $ActionTestOutputsConclusionResult = $env:ActionTestOutputsConclusion -eq $Actio
 $jobs = @(
     [PSCustomObject]@{
         Name               = 'Action-Test - [Src-SourceCode]'
-        Outcome            = $env:ActionTestSrcSourceCodeOutcome
-        ExpectedOutcome    = $ActionTestSrcSourceCodeExpectedOutcome
-        PassedOutcome      = $ActionTestSrcSourceCodeOutcomeResult
-        Conclusion         = $env:ActionTestSrcSourceCodeConclusion
-        ExpectedConclusion = $ActionTestSrcSourceCodeExpectedConclusion
-        PassedConclusion   = $ActionTestSrcSourceCodeConclusionResult
+        Outcome            = $env:SourceCodeOutcome
+        ExpectedOutcome    = $SourceCodeExpectedOutcome
+        PassedOutcome      = $SourceCodeOutcomeResult
+        Conclusion         = $env:SourceCodeConclusion
+        ExpectedConclusion = $SourceCodeExpectedConclusion
+        PassedConclusion   = $SourceCodeConclusionResult
     },
     [PSCustomObject]@{
         Name               = 'Action-Test - [Src-Custom]'
-        Outcome            = $env:ActionTestSrcCustomOutcome
-        ExpectedOutcome    = $ActionTestSrcCustomExpectedOutcome
-        PassedOutcome      = $ActionTestSrcCustomOutcomeResult
-        Conclusion         = $env:ActionTestSrcCustomConclusion
-        ExpectedConclusion = $ActionTestSrcCustomExpectedConclusion
-        PassedConclusion   = $ActionTestSrcCustomConclusionResult
+        Outcome            = $env:CustomOutcome
+        ExpectedOutcome    = $CustomExpectedOutcome
+        PassedOutcome      = $CustomOutcomeResult
+        Conclusion         = $env:CustomConclusion
+        ExpectedConclusion = $CustomExpectedConclusion
+        PassedConclusion   = $CustomConclusionResult
     },
     [PSCustomObject]@{
         Name               = 'Action-Test - [Src-WithManifest]'
-        Outcome            = $env:ActionTestSrcWithManifestOutcome
-        ExpectedOutcome    = $ActionTestSrcWithManifestExpectedOutcome
-        PassedOutcome      = $ActionTestSrcWithManifestOutcomeResult
-        Conclusion         = $env:ActionTestSrcWithManifestConclusion
-        ExpectedConclusion = $ActionTestSrcWithManifestExpectedConclusion
-        PassedConclusion   = $ActionTestSrcWithManifestConclusionResult
+        Outcome            = $env:WithManifestOutcome
+        ExpectedOutcome    = $WithManifestExpectedOutcome
+        PassedOutcome      = $WithManifestOutcomeResult
+        Conclusion         = $env:WithManifestConclusion
+        ExpectedConclusion = $WithManifestExpectedConclusion
+        PassedConclusion   = $WithManifestConclusionResult
     },
     [PSCustomObject]@{
         Name               = 'Action-Test - [Src-WithManifest-Default]'
-        Outcome            = $env:ActionTestSrcWithManifestDefaultOutcome
-        ExpectedOutcome    = $ActionTestSrcWithManifestDefaultExpectedOutcome
-        PassedOutcome      = $ActionTestSrcWithManifestDefaultOutcomeResult
-        Conclusion         = $env:ActionTestSrcWithManifestDefaultConclusion
-        ExpectedConclusion = $ActionTestSrcWithManifestDefaultExpectedConclusion
-        PassedConclusion   = $ActionTestSrcWithManifestDefaultConclusionResult
+        Outcome            = $env:WithManifestDefaultOutcome
+        ExpectedOutcome    = $WithManifestDefaultExpectedOutcome
+        PassedOutcome      = $WithManifestDefaultOutcomeResult
+        Conclusion         = $env:WithManifestDefaultConclusion
+        ExpectedConclusion = $WithManifestDefaultExpectedConclusion
+        PassedConclusion   = $WithManifestDefaultConclusionResult
     },
     [PSCustomObject]@{
         Name               = 'Action-Test - [outputs]'