Address PR #77 review threads: cache resilience, variant dedupe, docs, and perf schema

Author: MariusStorhaug

README.md

@@ -87,6 +87,21 @@ If the command returns results, the font is installed. If it returns nothing, th
 
 When you run `Install-NerdFont` again without `-Force`, fonts that are already installed in the requested scope are skipped. Downloaded archives are also cached per Nerd Fonts release so retries and repeated installs do not need to fetch the same ZIP again.
 
+Cache locations:
+
+- Windows: `%LOCALAPPDATA%/PSModule/NerdFonts/cache`
+- macOS and Linux: `$HOME/.cache/PSModule/NerdFonts`
+
+You can inspect the active cache path in PowerShell with:
+
+```powershell
+if ($IsWindows) {
+    Join-Path ([Environment]::GetFolderPath('LocalApplicationData')) 'PSModule/NerdFonts/cache'
+} else {
+    Join-Path $HOME '.cache/PSModule/NerdFonts'
+}
+```
+
 ### Update an installed NerdFont
 
 Individual font files do not embed a NerdFonts release version, so there is no direct way to check whether an installed

scripts/perf-results.jsonl

@@ -22,7 +22,7 @@
 {"Iteration":"1.0.33-pre006-variant-all","Scenario":"Single-Hack","DurationMs":1171,"DurationS":1.17,"Timestamp":"2026-05-17T14:05:52.0905786+02:00","Error":null,"Module":"1.0.33"}
 {"Iteration":"1.0.33-pre006-variant-all","Scenario":"Subset-Hack+FiraCode+JetBrainsMono","DurationMs":6096,"DurationS":6.1,"Timestamp":"2026-05-17T14:06:02.0498948+02:00","Error":null,"Module":"1.0.33"}
 {"Iteration":"1.0.33-pre006-variant-all","Scenario":"Subset-AlreadyInstalled","DurationMs":35,"DurationS":0.04,"Timestamp":"2026-05-17T14:06:02.1490854+02:00","Error":null,"Module":"1.0.33"}
-{"timestampUtc":"2026-05-17T12:06:18.1677417Z","iteration":"1.0.33-pre006-variant-mono","scenario":"Subset-Mono","durationSeconds":1.62,"moduleVersion":"1.0.33-pre006"}
+{"Iteration":"1.0.33-pre006-variant-mono","Scenario":"Subset-Mono","DurationMs":1620,"DurationS":1.62,"Timestamp":"2026-05-17T12:06:18.1677417Z","Error":null,"Module":"1.0.33"}
 {"Iteration":"1.0.33-pre007-parallel","Scenario":"Single-Hack","DurationMs":615,"DurationS":0.61,"Timestamp":"2026-05-17T14:32:21.0280298+02:00","Error":null,"Module":"1.0.33"}
 {"Iteration":"1.0.33-pre007-parallel","Scenario":"Subset-Hack+FiraCode+JetBrainsMono","DurationMs":3695,"DurationS":3.7,"Timestamp":"2026-05-17T14:32:24.9507727+02:00","Error":null,"Module":"1.0.33"}
 {"Iteration":"1.0.33-pre007-parallel","Scenario":"Subset-AlreadyInstalled","DurationMs":16,"DurationS":0.02,"Timestamp":"2026-05-17T14:32:25.0140743+02:00","Error":null,"Module":"1.0.33"}

src/functions/public/Install-NerdFont.ps1

@@ -147,7 +147,8 @@ Please run the command again with elevated rights (Run as Administrator) or prov
 
         Add-Type -AssemblyName System.Net.Http -ErrorAction SilentlyContinue
         $httpClient = [System.Net.Http.HttpClient]::new()
-        $httpClient.Timeout = [TimeSpan]::FromMinutes(5)
+        # Keep request lifetime unbounded for large archives on slower links.
+        $httpClient.Timeout = [System.Threading.Timeout]::InfiniteTimeSpan
         $pending = [System.Collections.Generic.List[object]]::new()
         $readyToInstall = [System.Collections.Generic.List[object]]::new()
         $throttle = [Math]::Max(1, [Environment]::ProcessorCount)
@@ -206,10 +207,6 @@ Please run the command again with elevated rights (Run as Administrator) or prov
                     try {
                         $bytes = $t.Task.GetAwaiter().GetResult()
                         [System.IO.File]::WriteAllBytes($t.Q.DownloadPath, $bytes)
-                        if (-not (Test-Path -LiteralPath $t.Q.CacheTagDir)) {
-                            $null = New-Item -ItemType Directory -Path $t.Q.CacheTagDir -Force
-                        }
-                        [System.IO.File]::WriteAllBytes($t.Q.CachedFile, $bytes)
                         $readyToInstall.Add($t.Q)
                     } catch {
                         Write-Error "[$($t.Q.Name)] - Download failed: $($_.Exception.Message)"
@@ -230,6 +227,18 @@ Please run the command again with elevated rights (Run as Administrator) or prov
                     $null = New-Item -ItemType Directory -Path $extractPath
                 }
                 [System.IO.Compression.ZipFile]::ExtractToDirectory($downloadPath, $extractPath, $true)
+
+                if (-not $p.FromCache -and (Test-Path -LiteralPath $downloadPath)) {
+                    try {
+                        if (-not (Test-Path -LiteralPath $p.CacheTagDir)) {
+                            $null = New-Item -ItemType Directory -Path $p.CacheTagDir -Force
+                        }
+                        Copy-Item -LiteralPath $downloadPath -Destination $p.CachedFile -Force
+                    } catch {
+                        Write-Warning "[$fontName] - Download succeeded but cache write failed: $($_.Exception.Message)"
+                    }
+                }
+
                 Remove-Item -Path $downloadPath -Force
             }
 
@@ -262,7 +271,22 @@ Please run the command again with elevated rights (Run as Administrator) or prov
                         $removed++
                     }
                 }
-                Write-Verbose "[$fontName] - Variant '$Variant' kept $($keep.Count) files, removed $removed"
+
+                # Nerd Fonts archives sometimes contain duplicate matching files in
+                # compatibility subfolders. Keep a single file per filename.
+                $remaining = @(Get-ChildItem -Path $extractPath -Recurse -File -Include '*.ttf', '*.otf')
+                $preferred = $remaining | Sort-Object 
+                    @{ Expression = { if ($_.FullName -match '(?i)[\\/]Windows Compatible[\\/]') { 1 } else { 0 } } },
+                    @{ Expression = { $_.FullName.Length } }
+                $seenFileNames = [System.Collections.Generic.HashSet[string]]::new([System.StringComparer]::OrdinalIgnoreCase)
+                $duplicateRemoved = 0
+                foreach ($file in $preferred) {
+                    if ($seenFileNames.Add($file.Name)) { continue }
+                    Remove-Item -LiteralPath $file.FullName -Force -ErrorAction SilentlyContinue
+                    $duplicateRemoved++
+                }
+
+                Write-Verbose "[$fontName] - Variant '$Variant' kept $($keep.Count) files, removed $removed and deduplicated $duplicateRemoved duplicates"
             }
 
             Write-Verbose "[$fontName] - Install to [$Scope]"

tests/NerdFonts.Tests.ps1

@@ -121,5 +121,68 @@ Describe 'Module' {
                 $script:NerdFonts = $originalFonts
             }
         }
+
+        It 'Install-NerdFont - Deduplicates variant files from cached archives' {
+            . (Join-Path -Path $PSScriptRoot -ChildPath '..\src\functions\public\Install-NerdFont.ps1')
+
+            $originalFonts = $script:NerdFonts
+            $fontName = 'DuplicateMonoTest'
+            $cacheRoot = if ($IsWindows) {
+                Join-Path -Path ([Environment]::GetFolderPath('LocalApplicationData')) -ChildPath 'PSModule/NerdFonts/cache'
+            } else {
+                Join-Path -Path $HOME -ChildPath '.cache/PSModule/NerdFonts'
+            }
+            $cacheTagDir = Join-Path -Path $cacheRoot -ChildPath 'v3.4.0'
+            $zipPath = Join-Path -Path $cacheTagDir -ChildPath 'DuplicateMonoTest.zip'
+
+            try {
+                if (-not (Test-Path -LiteralPath $cacheTagDir)) {
+                    $null = New-Item -ItemType Directory -Path $cacheTagDir -Force
+                }
+
+                $zipRoot = Join-Path -Path $TestDrive -ChildPath 'dup-zip'
+                $primaryDir = Join-Path -Path $zipRoot -ChildPath 'Primary'
+                $compatDir = Join-Path -Path $zipRoot -ChildPath 'Windows Compatible'
+                $null = New-Item -ItemType Directory -Path $primaryDir -Force
+                $null = New-Item -ItemType Directory -Path $compatDir -Force
+
+                $fileName = 'DuplicateMonoTestNerdFontMono-Regular.ttf'
+                Set-Content -Path (Join-Path -Path $primaryDir -ChildPath $fileName) -Value 'primary'
+                Set-Content -Path (Join-Path -Path $compatDir -ChildPath $fileName) -Value 'compat'
+
+                Add-Type -AssemblyName System.IO.Compression.FileSystem -ErrorAction SilentlyContinue
+                if (Test-Path -LiteralPath $zipPath) {
+                    Remove-Item -LiteralPath $zipPath -Force
+                }
+                [System.IO.Compression.ZipFile]::CreateFromDirectory($zipRoot, $zipPath)
+
+                $script:NerdFonts = @(
+                    [pscustomobject]@{
+                        Name = $fontName
+                        URL  = 'https://github.com/ryanoasis/nerd-fonts/releases/download/v3.4.0/DuplicateMonoTest.zip'
+                    }
+                )
+
+                Mock Get-Font { @() }
+                Mock Install-Font {
+                    param([string]$Path)
+                    $script:InstalledFontFiles = @(
+                        Get-ChildItem -Path $Path -Recurse -File -Include '*.ttf', '*.otf' |
+                            Select-Object -ExpandProperty Name
+                    )
+                }
+
+                { Install-NerdFont -Name $fontName -Variant Mono -ErrorAction Stop } | Should -Not -Throw
+                Should -Invoke Install-Font -Times 1 -Exactly
+                $script:InstalledFontFiles.Count | Should -Be 1
+                ($script:InstalledFontFiles | Select-Object -Unique).Count | Should -Be 1
+            } finally {
+                if (Test-Path -LiteralPath $zipPath) {
+                    Remove-Item -LiteralPath $zipPath -Force -ErrorAction SilentlyContinue
+                }
+                $script:NerdFonts = $originalFonts
+                Remove-Variable -Name InstalledFontFiles -Scope Script -ErrorAction SilentlyContinue
+            }
+        }
     }
 }