Handle partial download failures in Install-NerdFont

Author: MariusStorhaug

README.md

@@ -85,7 +85,7 @@ Get-Font -Name 'FiraCode*' -Scope AllUsers
 
 If the command returns results, the font is installed. If it returns nothing, the font is not installed in that scope.
 
-When you run `Install-NerdFont` again without `-Force`, fonts that are already installed in the requested scope are skipped. Downloaded archives are also cached per Nerd Fonts release so retries and repeated installs do not need to fetch the same zip again.
+When you run `Install-NerdFont` again without `-Force`, fonts that are already installed in the requested scope are skipped. Downloaded archives are also cached per Nerd Fonts release so retries and repeated installs do not need to fetch the same ZIP again.
 
 ### Update an installed NerdFont
 
@@ -103,7 +103,7 @@ Install-NerdFont -Name 'FiraCode' -Force -Scope AllUsers
 ```
 
 This re-downloads and installs the font version bundled with your installed NerdFonts module, overwriting any existing
-files. `-Force` also bypasses the local archive cache so the font zip is fetched again before reinstalling. To pick up newer font releases, update the NerdFonts module first (`Update-PSResource -Name NerdFonts` if you
+files. `-Force` also bypasses the local archive cache so the font ZIP is fetched again before reinstalling. To pick up newer font releases, update the NerdFonts module first (`Update-PSResource -Name NerdFonts` if you
 installed via PSResourceGet, or `Update-Module -Name NerdFonts` if you installed via PowerShellGet).
 
 ### Uninstall a NerdFont

scripts/Measure-InstallPerformance.ps1

@@ -46,6 +46,10 @@ param(
 $ErrorActionPreference = 'Stop'
 
 function Invoke-Uninstall {
+    <#
+        .SYNOPSIS
+            Removes matching Nerd Font families for the current user.
+    #>
     param([string[]]$Names)
     foreach ($n in $Names) {
         # Nerd Fonts archives expand to multiple family names that all start
@@ -62,11 +66,19 @@ function Invoke-Uninstall {
 }
 
 function Invoke-UninstallAll {
+    <#
+        .SYNOPSIS
+            Removes all Nerd Fonts known to the current module.
+    #>
     $names = (Get-NerdFont).Name
     Invoke-Uninstall -Names $names
 }
 
 function Measure-Scenario {
+    <#
+        .SYNOPSIS
+            Runs one setup/action performance scenario and records the result.
+    #>
     param(
         [string]$Name,
         [scriptblock]$Setup,

src/functions/public/Install-NerdFont.ps1

@@ -149,6 +149,7 @@ Please run the command again with elevated rights (Run as Administrator) or prov
         $httpClient = [System.Net.Http.HttpClient]::new()
         $httpClient.Timeout = [TimeSpan]::FromMinutes(5)
         $pending = [System.Collections.Generic.List[object]]::new()
+        $readyToInstall = [System.Collections.Generic.List[object]]::new()
         $throttle = 8
 
         try {
@@ -169,14 +170,16 @@ Please run the command again with elevated rights (Run as Administrator) or prov
                 if ((Test-Path -LiteralPath $cachedFile) -and -not $Force) {
                     Write-Verbose "[$fontName] - Cache hit at [$cachedFile]"
                     Copy-Item -LiteralPath $cachedFile -Destination $downloadPath -Force
-                    $pending.Add([pscustomobject]@{
+                    $item = [pscustomobject]@{
                             Name         = $fontName
                             URL          = $URL
                             DownloadPath = $downloadPath
                             CachedFile   = $cachedFile
                             CacheTagDir  = $cacheTagDir
                             FromCache    = $true
-                        })
+                        }
+                    $pending.Add($item)
+                    $readyToInstall.Add($item)
                 } else {
                     Write-Verbose "[$fontName] - Queue download to [$downloadPath]"
                     $pending.Add([pscustomobject]@{
@@ -199,19 +202,24 @@ Please run the command again with elevated rights (Run as Administrator) or prov
                     $tasks += [pscustomobject]@{ Q = $q; Task = $httpClient.GetByteArrayAsync($q.URL) }
                 }
                 foreach ($t in $tasks) {
-                    $bytes = $t.Task.GetAwaiter().GetResult()
-                    [System.IO.File]::WriteAllBytes($t.Q.DownloadPath, $bytes)
-                    if (-not (Test-Path -LiteralPath $t.Q.CacheTagDir)) {
-                        $null = New-Item -ItemType Directory -Path $t.Q.CacheTagDir -Force
+                    try {
+                        $bytes = $t.Task.GetAwaiter().GetResult()
+                        [System.IO.File]::WriteAllBytes($t.Q.DownloadPath, $bytes)
+                        if (-not (Test-Path -LiteralPath $t.Q.CacheTagDir)) {
+                            $null = New-Item -ItemType Directory -Path $t.Q.CacheTagDir -Force
+                        }
+                        [System.IO.File]::WriteAllBytes($t.Q.CachedFile, $bytes)
+                        $readyToInstall.Add($t.Q)
+                    } catch {
+                        Write-Error "[$($t.Q.Name)] - Download failed: $($_.Exception.Message)"
                     }
-                    [System.IO.File]::WriteAllBytes($t.Q.CachedFile, $bytes)
                 }
             }
         } finally {
             $httpClient.Dispose()
         }
 
-        foreach ($p in $pending) {
+        foreach ($p in $readyToInstall) {
             $fontName = $p.Name
             $downloadPath = $p.DownloadPath
             $extractPath = Join-Path -Path $tempPath -ChildPath $fontName

tests/NerdFonts.Tests.ps1

@@ -40,6 +40,30 @@ Describe 'Module' {
             Get-Font -Name 'Tinos*' | Should -Not -BeNullOrEmpty
         }
 
+        It 'Install-NerdFont - Continues when one queued download fails' {
+            . (Join-Path -Path $PSScriptRoot -ChildPath '..\src\functions\public\Install-NerdFont.ps1')
+
+            $originalFonts = $script:NerdFonts
+            $loadedFonts = Get-Content -Path (Join-Path -Path $PSScriptRoot -ChildPath '..\src\FontsData.json') | ConvertFrom-Json
+            $goodFont = $loadedFonts | Where-Object Name -eq 'Tinos' | Select-Object -First 1
+
+            $script:NerdFonts = @(
+                [pscustomobject]@{
+                    Name = 'BrokenDownloadTest'
+                    URL  = 'https://github.com/ryanoasis/nerd-fonts/releases/download/v3.4.0/does-not-exist.zip'
+                },
+                $goodFont
+            )
+
+            try {
+                Mock Install-Font {}
+                { Install-NerdFont -Name @('BrokenDownloadTest', 'Tinos') -Force -ErrorAction SilentlyContinue } | Should -Not -Throw
+                Should -Invoke Install-Font -Times 1 -Exactly
+            } finally {
+                $script:NerdFonts = $originalFonts
+            }
+        }
+
         It 'Install-NerdFont - Installs a font with -Variant Mono' {
             { Install-NerdFont -Name 'Hack' -Variant Mono -Force } | Should -Not -Throw
             Get-Font -Name 'Hack*' | Should -Not -BeNullOrEmpty