fix: use unique artifact names in test workflow and address review comments

- Add ArtifactName input to action.yml (default: module) so callers can specify the artifact name for download-artifact
- Update Action-Test.yml to use unique artifact names (module-default, module-prerelease, module-unstamped) per job to avoid upload-artifact v7 name collision across parallel jobs
- Add -PathType Container to Test-Path for module directory validation
- Wrap Import-PowerShellDataFile in try/catch with actionable error message
- Remove redundant notesFilePath cleanup after finally block

Author: MariusStorhaug

.github/workflows/Action-Test.yml

@@ -29,7 +29,7 @@ jobs:
       - name: Upload module artifact
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
         with:
-          name: module
+          name: module-default
           path: tests/outputs/module
 
       - name: Action-Test
@@ -38,6 +38,7 @@ jobs:
           GITHUB_TOKEN: ${{ github.token }}
         with:
           Name: PSModuleTest
+          ArtifactName: module-default
           WorkingDirectory: tests
           APIKey: ${{ secrets.APIKEY }} # zizmor: ignore[secrets-outside-env] saved in org secrets as an intentional choice
           WhatIf: true
@@ -83,7 +84,7 @@ jobs:
       - name: Upload module artifact
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
         with:
-          name: module
+          name: module-prerelease
           path: tests/outputs/module-prerelease
 
       - name: Action-Test
@@ -92,6 +93,7 @@ jobs:
           GITHUB_TOKEN: ${{ github.token }}
         with:
           Name: PSModuleTest
+          ArtifactName: module-prerelease
           ModulePath: outputs/module-prerelease
           WorkingDirectory: tests
           APIKey: ${{ secrets.APIKEY }} # zizmor: ignore[secrets-outside-env] saved in org secrets as an intentional choice
@@ -142,7 +144,7 @@ jobs:
       - name: Upload module artifact
         uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
         with:
-          name: module
+          name: module-unstamped
           path: tests/outputs/module-unstamped
 
       - name: Action-Test
@@ -153,6 +155,7 @@ jobs:
           GITHUB_TOKEN: ${{ github.token }}
         with:
           Name: PSModuleTest
+          ArtifactName: module-unstamped
           ModulePath: outputs/module-unstamped
           WorkingDirectory: tests
           APIKey: ${{ secrets.APIKEY }} # zizmor: ignore[secrets-outside-env] saved in org secrets as an intentional choice

action.yml

@@ -37,6 +37,10 @@ inputs:
     description: When enabled along with UsePRBodyAsReleaseNotes, the release notes will begin with the pull request title as a H1 heading followed by the pull request body. The title will reference the pull request number.
     required: false
     default: 'true'
+  ArtifactName:
+    description: Name of the uploaded artifact to download. Must match the name used in the upstream upload-artifact step.
+    required: false
+    default: module
 
 runs:
   using: composite
@@ -52,7 +56,7 @@ runs:
     - name: Download module artifact
       uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
       with:
-        name: module
+        name: ${{ inputs.ArtifactName }}
         path: ${{ inputs.ModulePath }}
 
     - name: Publish Module

src/publish.ps1

@@ -47,7 +47,7 @@ LogGroup 'Load inputs' {
     } else {
         Join-Path -Path $env:GITHUB_WORKSPACE -ChildPath $modulePathInput -AdditionalChildPath $name
     }
-    if (-not (Test-Path -Path $modulePathCandidate)) {
+    if (-not (Test-Path -Path $modulePathCandidate -PathType Container)) {
         Write-Error ("Module directory not found at [$modulePathCandidate]. " +
             'Ensure the artifact contains a <ModulePath>/<Name>/ subdirectory layout.')
         exit 1
@@ -99,7 +99,12 @@ LogGroup 'Resolve version from manifest' {
         Write-Host '::warning::Test-ModuleManifest returned warnings (e.g. unresolved RequiredModules). Continuing with data-file validation.'
     }
 
-    $manifestData = Import-PowerShellDataFile -Path $manifestFilePath
+    try {
+        $manifestData = Import-PowerShellDataFile -Path $manifestFilePath
+    } catch {
+        Write-Error "Failed to import manifest data file [$manifestFilePath]: $($_.Exception.Message)"
+        exit 1
+    }
     $moduleVersion = $manifestData.ModuleVersion
     if (-not ($moduleVersion -match '^\d+\.\d+\.\d+$')) {
         Write-Error ("ModuleVersion [$moduleVersion] must be in Major.Minor.Patch format. " +
@@ -237,10 +242,6 @@ LogGroup 'Create GitHub release' {
         }
     }
 
-    if ($notesFilePath -and (Test-Path -Path $notesFilePath)) {
-        Remove-Item -Path $notesFilePath -Force
-    }
-
     # Attach the built module as a release artifact so consumers can download the exact
     # bytes that were tested and published to the PowerShell Gallery.
     $zipFileName = "$name-$publishPSVersion.zip"