fix: address copilot review - path normalization, fixture manifests, cleanup exit

Author: MariusStorhaug

.github/workflows/Action-Test.yml

@@ -45,7 +45,7 @@ jobs:
       - name: Validate module version is stamped
         shell: pwsh
         run: |
-          $manifestPath = 'tests/outputs/module/PSModuleTest/PSModuleTest.psd1'
+          $manifestPath = Join-Path $env:GITHUB_WORKSPACE 'outputs' 'module' 'PSModuleTest' 'PSModuleTest.psd1'
           $manifest = Import-PowerShellDataFile -Path $manifestPath
           $version = $manifest.ModuleVersion
           $releaseTag = $env:PSMODULE_PUBLISH_PSMODULE_CONTEXT_ReleaseTag
@@ -100,7 +100,7 @@ jobs:
       - name: Validate prerelease version
         shell: pwsh
         run: |
-          $manifestPath = 'tests/outputs/module-prerelease/PSModuleTest/PSModuleTest.psd1'
+          $manifestPath = Join-Path $env:GITHUB_WORKSPACE 'outputs' 'module-prerelease' 'PSModuleTest' 'PSModuleTest.psd1'
           $manifest = Import-PowerShellDataFile -Path $manifestPath
           $version = $manifest.ModuleVersion
           $prerelease = $manifest.PrivateData.PSData.Prerelease
@@ -163,7 +163,7 @@ jobs:
         env:
           PUBLISH_OUTCOME: ${{ steps.publish.outcome }}
         run: |
-          $manifestPath = 'tests/outputs/module-unstamped/PSModuleTest/PSModuleTest.psd1'
+          $manifestPath = Join-Path $env:GITHUB_WORKSPACE 'outputs' 'module-unstamped' 'PSModuleTest' 'PSModuleTest.psd1'
           $manifest = Import-PowerShellDataFile -Path $manifestPath
           $version = $manifest.ModuleVersion
           $releaseTag = $env:PSMODULE_PUBLISH_PSMODULE_CONTEXT_ReleaseTag
@@ -172,8 +172,8 @@ jobs:
           Write-Host "Release tag from action:    [$releaseTag]"
           Write-Host "Publish step outcome:       [$env:PUBLISH_OUTCOME]"
 
-          if (-not [string]::IsNullOrEmpty($version) -and $version -ne '999.0.0') {
-            Write-Error "Expected missing or placeholder version but got [$version]."
+          if ($version -ne '999.0.0') {
+            Write-Error "Expected placeholder version [999.0.0] but got [$version]."
             exit 1
           }
           if ($env:PUBLISH_OUTCOME -eq 'success') {

src/cleanup.ps1

@@ -20,7 +20,7 @@ LogGroup 'Load inputs' {
 
     if ([string]::IsNullOrWhiteSpace($prereleaseName)) {
         Write-Host "No prerelease tag derivable from PR head ref [$prHeadRef]. Nothing to cleanup."
-        return
+        exit 0
     }
 
     Write-Host "PR head ref:      [$prHeadRef]"

src/publish.ps1

@@ -38,7 +38,15 @@ LogGroup 'Load inputs' {
     } else {
         $env:PSMODULE_PUBLISH_PSMODULE_INPUT_Name
     }
-    $modulePathCandidate = "$env:PSMODULE_PUBLISH_PSMODULE_INPUT_ModulePath/$name"
+    # Normalize to an absolute path anchored at the workspace root so that
+    # the resolved location agrees with where actions/download-artifact writes
+    # the artifact (workspace-root-relative), regardless of WorkingDirectory.
+    $modulePathInput = $env:PSMODULE_PUBLISH_PSMODULE_INPUT_ModulePath
+    $modulePathCandidate = if ([System.IO.Path]::IsPathRooted($modulePathInput)) {
+        Join-Path $modulePathInput $name
+    } else {
+        Join-Path $env:GITHUB_WORKSPACE $modulePathInput $name
+    }
     if (-not (Test-Path -Path $modulePathCandidate)) {
         Write-Error ("Module directory not found at [$modulePathCandidate]. " +
             'Ensure the artifact contains a <ModulePath>/<Name>/ subdirectory layout.')

tests/outputs/module-unstamped/PSModuleTest/PSModuleTest.psd1

@@ -1,62 +1,26 @@
 @{
-    RootModule            = 'PSModuleTest.psm1'
-    CompatiblePSEditions  = @(
+    RootModule           = 'PSModuleTest.psm1'
+    ModuleVersion        = '999.0.0'
+    CompatiblePSEditions = @(
         'Core'
         'Desktop'
     )
-    GUID                  = '20b37221-db1c-43db-9cca-f22b33123548'
-    Author                = 'PSModule'
-    CompanyName           = 'PSModule'
-    Copyright             = '(c) 2024 PSModule. All rights reserved.'
-    Description           = 'Process a module from source code to published module.'
-    PowerShellVersion     = '5.1'
-    ProcessorArchitecture = 'None'
-    RequiredModules       = @(
-        @{
-            ModuleVersion = '1.0'
-            ModuleName    = 'PSSemVer'
-        }
-        'Utilities'
-    )
-    RequiredAssemblies    = 'assemblies/LsonLib.dll'
-    ScriptsToProcess      = 'scripts/loader.ps1'
-    TypesToProcess        = @(
-        'types/DirectoryInfo.Types.ps1xml'
-        'types/FileInfo.Types.ps1xml'
-    )
-    FormatsToProcess      = @(
-        'formats/CultureInfo.Format.ps1xml'
-        'formats/Mygciview.Format.ps1xml'
-    )
-    NestedModules         = @(
-        'modules/OtherPSModule.psm1'
-    )
-    FunctionsToExport     = @(
+    GUID                 = '20b37221-db1c-43db-9cca-f22b33123548'
+    Author               = 'PSModule'
+    CompanyName          = 'PSModule'
+    Copyright            = '(c) 2024 PSModule. All rights reserved.'
+    Description          = 'Process a module from source code to published module.'
+    PowerShellVersion    = '5.1'
+    FunctionsToExport    = @(
         'Get-PSModuleTest'
         'New-PSModuleTest'
         'Set-PSModuleTest'
         'Test-PSModuleTest'
     )
-    CmdletsToExport       = @()
-    VariablesToExport     = @()
-    AliasesToExport       = '*'
-    ModuleList            = @(
-        'modules/OtherPSModule.psm1'
-    )
-    FileList              = @(
-        'PSModuleTest.psd1'
-        'PSModuleTest.psm1'
-        'assemblies/LsonLib.dll'
-        'data/Config.psd1'
-        'data/Settings.psd1'
-        'formats/CultureInfo.Format.ps1xml'
-        'formats/Mygciview.Format.ps1xml'
-        'modules/OtherPSModule.psm1'
-        'scripts/loader.ps1'
-        'types/DirectoryInfo.Types.ps1xml'
-        'types/FileInfo.Types.ps1xml'
-    )
-    PrivateData           = @{
+    CmdletsToExport      = @()
+    VariablesToExport    = @()
+    AliasesToExport      = @()
+    PrivateData          = @{
         PSData = @{
             Tags       = @(
                 'workflow'