Make ReleaseType required and remove autodetection fallback

Author: MariusStorhaug

action.yml

@@ -50,9 +50,8 @@ inputs:
     required: false
     default: NoRelease
   ReleaseType:
-    description: The type of release to create. Values are 'Release' (stable), 'Prerelease', 'Cleanup' (delete old prereleases), or 'None'. When set, this overrides automatic detection.
-    required: false
-    default: ''
+    description: The type of release to create. Values are 'Release' (stable), 'Prerelease', 'Cleanup' (delete old prereleases), or 'None'. This input is required and must be provided by the caller.
+    required: true
   WhatIf:
     description: If specified, the action will only log the changes it would make, but will not actually create or delete any releases or tags.
     required: false

scripts/helpers/Publish-PSModule.ps1

@@ -104,11 +104,26 @@
     Set-GitHubLogGroup 'Calculate release type' {
         $prereleaseName = $prHeadRef -replace '[^a-zA-Z0-9]'
 
-        # ReleaseType is determined by Get-PSModuleSettings
+        # Validate ReleaseType - must be provided by Get-PSModuleSettings
+        $validReleaseTypes = @('Release', 'Prerelease', 'Cleanup', 'None')
+        if ([string]::IsNullOrWhiteSpace($releaseType)) {
+            Write-Error "ReleaseType input is required. Valid values are: $($validReleaseTypes -join ', ')"
+            exit 1
+        }
+        if ($releaseType -notin $validReleaseTypes) {
+            Write-Error "Invalid ReleaseType: [$releaseType]. Valid values are: $($validReleaseTypes -join ', ')"
+            exit 1
+        }
+
         $createRelease = $releaseType -eq 'Release'
         $createPrerelease = $releaseType -eq 'Prerelease'
         $closedPullRequest = $releaseType -eq 'Cleanup'
 
+        if ($releaseType -eq 'None') {
+            Write-Output 'ReleaseType is None. Skipping release creation.'
+            return
+        }
+
         $ignoreRelease = ($labels | Where-Object { $ignoreLabels -contains $_ }).Count -gt 0
         if ($ignoreRelease) {
             Write-Output 'Ignoring release creation due to ignore label.'