Fix conformance lint failures

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: MariusStorhaug

README.md

@@ -177,7 +177,7 @@ commit `45db50ae`). The pinned archive contains 402 inputs:
   documented projection policy.
 
 The two construction-policy differences are `565N`, where this module
-constructs `!!binary` as `byte[]` instead of a Base64 string, and `J7PZ`, where
+constructs `!!binary` as `byte[]` instead of a base64 string, and `J7PZ`, where
 the explicitly supported `!!omap` tag becomes an ordered dictionary instead of
 remaining a sequence of one-entry mappings. The deterministic runner reports
 398 passing cases, four policy exclusions, and no unexplained failures.

tests/Conformance.Tests.ps1

@@ -39,12 +39,13 @@ Describe 'Released yaml-test-suite corpus accounting' {
         @($suiteResults | Where-Object SyntaxResult -EQ 'Fail').Count | Should -Be 0
         @($suiteResults | Where-Object SyntaxResult -EQ 'NotApplicable').Count |
             Should -Be 0
-        @(
+        $syntaxPolicyCases = @(
             $suiteResults |
                 Where-Object SyntaxResult -EQ 'PolicyDifference' |
                 Select-Object -ExpandProperty Case |
                 Sort-Object
-        ) | Should -Be @('2JQS', 'X38W')
+        )
+        $syntaxPolicyCases | Should -Be @('2JQS', 'X38W')
     }
 
     It 'accounts for parser representation/event comparisons' {
@@ -63,12 +64,13 @@ Describe 'Released yaml-test-suite corpus accounting' {
         @($suiteResults | Where-Object JsonResult -EQ 'Fail').Count | Should -Be 0
         @($suiteResults | Where-Object JsonResult -EQ 'NotApplicable').Count |
             Should -Be 123
-        @(
+        $jsonPolicyCases = @(
             $suiteResults |
                 Where-Object JsonResult -EQ 'PolicyDifference' |
                 Select-Object -ExpandProperty Case |
                 Sort-Object
-        ) | Should -Be @('565N', 'J7PZ')
+        )
+        $jsonPolicyCases | Should -Be @('565N', 'J7PZ')
     }
 
     It 'accounts for out.yaml representation comparisons' {
@@ -90,14 +92,15 @@ Describe 'Released yaml-test-suite corpus accounting' {
     }
 
     It 'keeps the previously failing multi-document JSON cases green' {
-        @(
+        $jsonRegressions = @(
             $suiteResults |
                 Where-Object Case -In @(
                     '35KP', '6XDY', '6ZKB', '7Z25', '9DXL',
                     '9KAX', 'JHB9', 'KSS4', 'L383', 'M7A3',
                     'PUW8', 'RZT7', 'U9NS', 'UT92', 'W4TN'
                 ) |
                 Where-Object JsonResult -NE 'Pass'
-        ).Count | Should -Be 0
+        )
+        $jsonRegressions.Count | Should -Be 0
     }
 }

tests/Packaging.Tests.ps1

@@ -15,16 +15,28 @@ $script:repositoryRoot = $null
 $script:resolvedArtifactManifestPath = $null
 $script:artifactManifestPath = $null
 
+function Test-YamlArtifactManifestAvailable {
+    [CmdletBinding()]
+    [OutputType([bool])]
+    param()
+
+    if (-not [string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT)) {
+        return $true
+    }
+    $repositoryRoot = (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot '..')).Path
+    Test-Path -LiteralPath (Join-Path $repositoryRoot 'outputs\module\Yaml\Yaml.psd1') -PathType Leaf
+}
+
+$artifactManifestAvailable = Test-YamlArtifactManifestAvailable
+
 BeforeAll {
     . (Join-Path $PSScriptRoot 'TestBootstrap.ps1')
     $script:repositoryRoot = (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot '..')).Path
     $defaultArtifactManifestPath = Join-Path $script:repositoryRoot 'outputs\module\Yaml\Yaml.psd1'
-    $script:resolvedArtifactManifestPath = if (
-        -not [string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT)
-    ) {
-        $env:PSMODULE_YAML_TEST_ARTIFACT
-    } elseif (Test-Path -LiteralPath $defaultArtifactManifestPath -PathType Leaf) {
+    $script:resolvedArtifactManifestPath = if (Test-Path -LiteralPath $defaultArtifactManifestPath -PathType Leaf) {
         $defaultArtifactManifestPath
+    } elseif (-not [string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT)) {
+        $env:PSMODULE_YAML_TEST_ARTIFACT
     } else {
         $null
     }
@@ -85,8 +97,8 @@ Describe 'Dependency-free package source' {
             'ConvertTo-YamlNode.ps1',
             'Write-YamlNodeText.ps1'
         ) | ForEach-Object {
-            Test-Path -LiteralPath (Join-Path $privatePath $_) |
-                Should -BeTrue -Because "$_ defines a required processor layer"
+            $isPresent = Test-Path -LiteralPath (Join-Path $privatePath $_)
+            $isPresent | Should -BeTrue -Because "$_ defines a required processor layer"
         }
     }
 
@@ -121,7 +133,7 @@ Describe 'Dependency-free package source' {
 
 Describe 'Generated artifact package' {
     It 'has no RequiredAssemblies or packaged DLL and has a complete FileList' `
-        -Skip:([string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT) -and -not (Test-Path -LiteralPath (Join-Path (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot '..')).Path 'outputs\module\Yaml\Yaml.psd1') -PathType Leaf)) {
+        -Skip:(-not $artifactManifestAvailable) {
         $manifest = Import-PowerShellDataFile -Path $script:artifactManifestPath
         $moduleBase = Split-Path -Parent $script:artifactManifestPath
 
@@ -139,7 +151,9 @@ Describe 'Generated artifact package' {
     }
 
     It 'imports in a fresh PowerShell 7 process and preserves arrays, aliases, and depth' `
-        -Skip:(([string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT) -and -not (Test-Path -LiteralPath (Join-Path (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot '..')).Path 'outputs\module\Yaml\Yaml.psd1') -PathType Leaf)) -or $null -eq (Get-Command pwsh -ErrorAction SilentlyContinue)) {
+        -Skip:((
+            -not $artifactManifestAvailable
+        ) -or ($null -eq (Get-Command pwsh -ErrorAction SilentlyContinue))) {
         $script = @'
 $ErrorActionPreference = 'Stop'
 $ps = $PSVersionTable.PSVersion

tests/tools/Invoke-YamlTestSuite.ps1

@@ -291,7 +291,7 @@ function ConvertFrom-YamlSuiteEventText {
         $builder.ToString()
     }
 
-    function ConvertFrom-YamlSuiteEventEscapes {
+    function ConvertFrom-YamlSuiteEventEscape {
         param ([AllowNull()][string] $Value)
         if ($null -eq $Value) {
             return ''
@@ -327,7 +327,7 @@ function ConvertFrom-YamlSuiteEventText {
     $lines = $Text -split '\r?\n'
 
     foreach ($rawLine in $lines) {
-    $line = $rawLine
+        $line = $rawLine
         if ([string]::IsNullOrWhiteSpace($line)) {
             continue
         }
@@ -392,7 +392,7 @@ function ConvertFrom-YamlSuiteEventText {
                     $value = ''
                 }
                 $value = ConvertTo-YamlSuiteEventEscapedText -Value (
-                    ConvertFrom-YamlSuiteEventEscapes -Value $value
+                    ConvertFrom-YamlSuiteEventEscape -Value $value
                 )
             }