Fix CI artifact path and linter gates

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: MariusStorhaug

tests/Packaging.Tests.ps1

@@ -8,6 +8,10 @@
     'PSUseDeclaredVarsMoreThanAssignments', '',
     Justification = 'Required for Pester tests'
 )]
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+    'PSProvideCommentHelp', '',
+    Justification = 'Internal test helper function for packaging assertions.'
+)]
 [CmdletBinding()]
 param()
 
@@ -16,8 +20,6 @@ $script:resolvedArtifactManifestPath = $null
 $script:artifactManifestPath = $null
 
 function Test-YamlArtifactManifestAvailable {
-    [CmdletBinding()]
-    [OutputType([bool])]
     param()
 
     if (-not [string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT)) {
@@ -33,23 +35,20 @@ BeforeAll {
     . (Join-Path $PSScriptRoot 'TestBootstrap.ps1')
     $script:repositoryRoot = (Resolve-Path -LiteralPath (Join-Path $PSScriptRoot '..')).Path
     $defaultArtifactManifestPath = Join-Path $script:repositoryRoot 'outputs\module\Yaml\Yaml.psd1'
-    $script:resolvedArtifactManifestPath = if (Test-Path -LiteralPath $defaultArtifactManifestPath -PathType Leaf) {
-        $defaultArtifactManifestPath
+    $script:resolvedArtifactManifestPath = if (
+        Test-Path -LiteralPath $defaultArtifactManifestPath -PathType Leaf
+    ) {
+        (Resolve-Path -LiteralPath $defaultArtifactManifestPath).Path
     } elseif (-not [string]::IsNullOrWhiteSpace($env:PSMODULE_YAML_TEST_ARTIFACT)) {
-        $env:PSMODULE_YAML_TEST_ARTIFACT
-    } else {
-        $null
-    }
-    $loadedYamlModule = if (-not [string]::IsNullOrWhiteSpace($script:resolvedArtifactManifestPath)) {
-        Import-Module -Name $script:resolvedArtifactManifestPath -Force -Global -PassThru |
-            Where-Object Name -EQ 'Yaml' |
-            Select-Object -First 1
-    }
-    $script:artifactManifestPath = if ($null -ne $loadedYamlModule) {
-        Join-Path $loadedYamlModule.ModuleBase 'Yaml.psd1'
+        if (Test-Path -LiteralPath $env:PSMODULE_YAML_TEST_ARTIFACT -PathType Leaf) {
+            (Resolve-Path -LiteralPath $env:PSMODULE_YAML_TEST_ARTIFACT).Path
+        } else {
+            $null
+        }
     } else {
         $null
     }
+    $script:artifactManifestPath = $script:resolvedArtifactManifestPath
 }
 
 Describe 'Dependency-free package source' {

tests/tools/Invoke-YamlTestSuite.ps1

@@ -1,3 +1,7 @@
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+    'PSProvideCommentHelp', '',
+    Justification = 'Internal test helper functions in this tooling script.'
+)]
 [CmdletBinding()]
 param (
     [Parameter(Mandatory)]
@@ -23,7 +27,6 @@ if (-not $PSBoundParameters.ContainsKey('CompareJson') -and
 }
 
 function Invoke-InYamlModule {
-    [CmdletBinding()]
     param (
         [Parameter(Mandatory)]
         [scriptblock] $ScriptBlock,
@@ -40,7 +43,6 @@ function Invoke-InYamlModule {
 }
 
 function Split-YamlSuiteJsonDocument {
-    [CmdletBinding()]
     param (
         [Parameter(Mandatory)]
         [AllowEmptyString()]
@@ -111,8 +113,6 @@ function Split-YamlSuiteJsonDocument {
 }
 
 function ConvertTo-YamlSuiteCanonicalValue {
-    [CmdletBinding()]
-    [OutputType([string])]
     param (
         [AllowNull()]
         [object] $Value
@@ -173,7 +173,6 @@ function ConvertTo-YamlSuiteCanonicalValue {
 }
 
 function ConvertTo-YamlSuiteReferenceSignature {
-    [CmdletBinding()]
     [OutputType([string])]
     param (
         [AllowNull()]
@@ -244,7 +243,6 @@ function ConvertTo-YamlSuiteReferenceSignature {
 }
 
 function Get-YamlSuitePolicyReason {
-    [CmdletBinding()]
     [OutputType([string])]
     param (
         [string] $YamlText,
@@ -266,7 +264,6 @@ function Get-YamlSuitePolicyReason {
 }
 
 function ConvertFrom-YamlSuiteEventText {
-    [CmdletBinding()]
     [OutputType([string[]])]
     param (
         [Parameter(Mandatory)]
@@ -433,7 +430,6 @@ function ConvertFrom-YamlSuiteEventText {
 }
 
 function ConvertTo-YamlSuiteActualEvent {
-    [CmdletBinding()]
     [OutputType([string[]])]
     param (
         [Parameter(Mandatory)]
@@ -540,7 +536,6 @@ function ConvertTo-YamlSuiteActualEvent {
 }
 
 function Compare-YamlSuiteCanonicalList {
-    [CmdletBinding()]
     [OutputType([bool])]
     param (
         [string[]] $Left,
@@ -559,7 +554,6 @@ function Compare-YamlSuiteCanonicalList {
 }
 
 function Get-YamlSuiteAnchorToken {
-    [CmdletBinding()]
     [OutputType([string])]
     param (
         [Parameter(Mandatory)]