Remove inferred test for EAGO.Optimizer#144
Closed
odow wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the bringing this up. Long term it's probably better to use the new type-stable constructor everywhere, so I made #146 based on the latter approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently moved the MOI interface of Ipopt to a package extension (because many people wanted to use Ipopt but not MOI, and it's a fairly hefty dependency for them to carry around and compile).
The downside is that
Ipopt.Optimizeris no longer type stable: https://github.com/jump-dev/Ipopt.jl?tab=readme-ov-file#type-stabilityThis shows up in your default
EAGO.Optimizerconstructor, which is now also not type stable.We have two options:
Ipopt = "1.10"and use the type-stable constructorIpoptMathOptInterfaceExt.Optimizer.I went for the former. I can make a PR for the latter if you'd prefer.