Use review marker only for stale review dismissal

Author: matej

scripts/comment-pr-findings.bun.test.js

@@ -849,7 +849,7 @@ describe('comment-pr-findings.js', () => {
   });
 
   describe('Stale Review Handling', () => {
-    test('should only dismiss own bot reviews when DISMISS_STALE_REVIEWS is true', async () => {
+    test('should only dismiss marker-tagged reviews when DISMISS_STALE_REVIEWS is true', async () => {
       process.env.DISMISS_STALE_REVIEWS = 'true';
 
       const mockFindings = [{
@@ -864,13 +864,13 @@ describe('comment-pr-findings.js', () => {
 
       const mockReviews = [
         // Our reviews - should be dismissed
-        { id: 101, state: 'CHANGES_REQUESTED', user: { type: 'Bot' }, body: 'Found 3 security issues. Please address the high-severity issues before merging.' },
-        { id: 102, state: 'APPROVED', user: { type: 'Bot' }, body: 'No issues found. Changes look good.' },
+        { id: 101, state: 'CHANGES_REQUESTED', user: { type: 'Bot' }, body: 'Found 3 security issues. Please address the high-severity issues before merging.\n\n<!-- nutrient-code-review-action -->' },
+        { id: 102, state: 'APPROVED', user: { type: 'Bot' }, body: 'No issues found. Changes look good.\n\n<!-- nutrient-code-review-action -->' },
         // Other bot reviews - should NOT be dismissed
         { id: 103, state: 'APPROVED', user: { type: 'Bot' }, body: 'Dependabot has approved this PR.' },
         { id: 104, state: 'CHANGES_REQUESTED', user: { type: 'Bot' }, body: 'Renovate: This PR has conflicts.' },
         // COMMENTED state - should NOT be dismissed
-        { id: 105, state: 'COMMENTED', user: { type: 'Bot' }, body: 'Found 1 security issue.' },
+        { id: 105, state: 'COMMENTED', user: { type: 'Bot' }, body: 'Found 1 security issue.\n\n<!-- nutrient-code-review-action -->' },
         // User review - should NOT be dismissed
         { id: 106, state: 'CHANGES_REQUESTED', user: { type: 'User' }, body: 'Please fix the typo.' }
       ];

scripts/comment-pr-findings.js

@@ -92,26 +92,7 @@ function addReactionsToReview(reviewId) {
 // Check if a review was posted by this action
 function isOwnReview(review) {
   if (!review.body) return false;
-  if (review.body.includes(REVIEW_MARKER)) return true;
-
-  // Check for our review summary patterns
-  const ownPatterns = [
-    'No issues found. Changes look good.',
-    /^Found \d+ .+ issues?\./,
-    'Please address the high-severity issues before merging.',
-    'Consider addressing the suggestions in the comments.',
-    'Minor suggestions noted in comments.'
-  ];
-
-  for (const pattern of ownPatterns) {
-    if (pattern instanceof RegExp) {
-      if (pattern.test(review.body)) return true;
-    } else {
-      if (review.body.includes(pattern)) return true;
-    }
-  }
-
-  return false;
+  return review.body.includes(REVIEW_MARKER);
 }
 
 // Helper function to dismiss stale bot reviews from this action only
@@ -127,12 +108,8 @@ function dismissStaleReviews() {
     for (const review of reviews) {
       const isDismissible = review.state === 'APPROVED' || review.state === 'CHANGES_REQUESTED';
       const isOwn = isOwnReview(review);
-      const hasMarker = Boolean(review.body && review.body.includes(REVIEW_MARKER));
-      const isBot = review.user && review.user.type === 'Bot';
-      const canDismissLegacyReview = isBot && isOwn;
-      const canDismissMarkedReview = hasMarker;
 
-      if (isDismissible && (canDismissMarkedReview || canDismissLegacyReview)) {
+      if (isDismissible && isOwn) {
         try {
           ghApi(
             `/repos/${context.repo.owner}/${context.repo.repo}/pulls/${context.issue.number}/reviews/${review.id}/dismissals`,