Skip to content

Commit 2a44d7c

Browse files
authored
Merge pull request #5 from PSWinCom/receiver-bad-reply
Make GatewayReceiver write correct response body
2 parents 1b4eb82 + f783ef4 commit 2a44d7c

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

PSWin.Client/LinkMobility.PSWin.Client.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
6-
<Version>1.2.0</Version>
6+
<Version>1.3.0</Version>
77
<Authors>Link Mobility NE</Authors>
88
<Company></Company>
99
<Description>Send SMS through PSWin gateway.</Description>

PSWin.Receiver/GatewayReceiver.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
using System;
66
using System.IO;
77
using System.Net;
8-
using System.Net.Http;
98
using System.Threading.Tasks;
109
using System.Xml;
1110
using System.Xml.Linq;
@@ -17,6 +16,7 @@ public class GatewayReceiver
1716
public delegate Task MoReceiver(MoMessage message);
1817
public delegate Task DrReceiver(DrMessage message);
1918

19+
private const string XmlOkResponse = "<?xml version=\"1.0\"?><MSGLST><MSG><ID>1</ID><STATUS>OK</STATUS></MSG></MSGLST>";
2020
private readonly MoReceiver moReceiver;
2121
private readonly DrReceiver drReceiver;
2222

@@ -31,7 +31,7 @@ public async Task ReceiveMobileOriginatedMessageAsync(HttpContext context)
3131
var body = await new StreamReader(context.Request.Body).ReadToEndAsync();
3232
var result = await ReceiveMobileOriginatedMessageAsync(body);
3333
context.Response.StatusCode = (int)result.status;
34-
await new StreamWriter(context.Response.Body).WriteAsync(result.responseBody);
34+
await HttpResponseWritingExtensions.WriteAsync(context.Response, result.responseBody);
3535
}
3636

3737
public async Task<(HttpStatusCode status, string responseBody)> ReceiveMobileOriginatedMessageAsync(string requestBody)
@@ -46,7 +46,7 @@ public async Task ReceiveMobileOriginatedMessageAsync(HttpContext context)
4646
{
4747
var momessage = MoParser.Parse(document);
4848
await moReceiver.Invoke(momessage);
49-
return (HttpStatusCode.OK, string.Empty);
49+
return (HttpStatusCode.OK, XmlOkResponse);
5050
}
5151
catch (MoParserException ex)
5252
{
@@ -63,7 +63,7 @@ public async Task ReceiveDeliveryReportAsync(HttpContext context)
6363
var body = await new StreamReader(context.Request.Body).ReadToEndAsync();
6464
var result = await ReceiveDeliveryReportAsync(body);
6565
context.Response.StatusCode = (int)result.status;
66-
await new StreamWriter(context.Response.Body).WriteAsync(result.responseBody);
66+
await HttpResponseWritingExtensions.WriteAsync(context.Response, result.responseBody);
6767
}
6868

6969
public async Task<(HttpStatusCode status, string responseBody)> ReceiveDeliveryReportAsync(string requestBody)
@@ -78,7 +78,7 @@ public async Task ReceiveDeliveryReportAsync(HttpContext context)
7878
{
7979
var drmessage = DrParser.Parse(document);
8080
await drReceiver.Invoke(drmessage);
81-
return (HttpStatusCode.OK, string.Empty);
81+
return (HttpStatusCode.OK, XmlOkResponse);
8282
}
8383
catch (DrParserException ex)
8484
{

PSWin.Receiver/LinkMobility.PSWin.Receiver.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
6-
<Version>1.1.0</Version>
6+
<Version>1.3.0</Version>
77
<Company></Company>
88
<Authors>Link Mobility NE</Authors>
99
<Description>Receive mobile originated messages and delivery reports from PSWin gateway.</Description>

0 commit comments

Comments
 (0)