fix(navigator): invalidate next setpoint when waypoint yaw is not aligned#26919
Open
Luka-Filipovic wants to merge 1 commit intoPX4:mainfrom
Open
fix(navigator): invalidate next setpoint when waypoint yaw is not aligned#26919Luka-Filipovic wants to merge 1 commit intoPX4:mainfrom
Luka-Filipovic wants to merge 1 commit intoPX4:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
When a rotary wing waypoint requires yaw alignment, the next position setpoint
remains valid during approach. This causes FlightTaskAuto to plan a fly-through
trajectory instead of decelerating, so the vehicle overshoots the waypoint
before aligning yaw.
Solution
next.validwhen the current waypoint requires yaw acceptance,and re-enable it dynamically once yaw is aligned (
_next_sp_awaits_yaw).checked during approach. Once both position and yaw are reached the state
latches to avoid interfering with hold time. This keeps the existing logic unchanged.
Changelog Entry
Bugfix: Multicopter missions now brake at waypoints requiring yaw alignment
Alternatives
Test coverage
TODO