feat(allyes): Remove redundant filters from exception_list_sitl#26937
Merged
feat(allyes): Remove redundant filters from exception_list_sitl#26937
Conversation
826dc0d to
4d70217
Compare
6499350 to
9ed3b8e
Compare
dakejahl
reviewed
Apr 3, 2026
3a37f18 to
fbd8f1e
Compare
Contributor
Author
|
If I disable clang-tidy checks for "libvnc" as all, the error: "Error: no checks enabled" occurs. |
dakejahl
previously approved these changes
Apr 13, 2026
0c80fef to
4933350
Compare
mrpollo
reviewed
Apr 24, 2026
6fcecb5 to
2b742a0
Compare
mrpollo
approved these changes
Apr 24, 2026
Contributor
mrpollo
left a comment
There was a problem hiding this comment.
The allyes fix is exactly right. The bare COMMON/DRIVERS prefixes were silently eating every driver including UART-only ones, and the surgical exclusion list is the right shape. Restoring real CI coverage here also surfaced a backlog of legitimate driver fixes (vectornav missing brace, sbgecom short-read + leak, vtxtable open() mode, vertiq_io proper EINTR/EAGAIN handling) that were hiding behind that hole.
Rebase-merging this so the per-driver commits stay individually bisectable.
Thanks for picking this up and running it all the way through, @valbv.
Contributor
Author
|
Thank you guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
INS-drivers had errors and can't build.
Currently, INS-drivers buildability isn't checked when merging pull-requests.
After these changes b7c5ba1 it was stopped.
Because of this, build-errors in this code-base go unnoticed.
Solution
INS-drivers build fixed.
Clang-tidy errors fixed.
Code-style errors (astyle) fixed in the separate commits.
Build more targets in
px4_sitl_allyes:Exclude specific targets from build instead of redundant big filters
COMMONandDRIVERSinTools/kconfig/allyesconfig.pyChangelog Entry
For release notes: