Skip to content

feat(allyes): Remove redundant filters from exception_list_sitl#26937

Merged
mrpollo merged 13 commits intoPX4:mainfrom
inertiallabs:ins_fix
Apr 24, 2026
Merged

feat(allyes): Remove redundant filters from exception_list_sitl#26937
mrpollo merged 13 commits intoPX4:mainfrom
inertiallabs:ins_fix

Conversation

@valbv
Copy link
Copy Markdown
Contributor

@valbv valbv commented Apr 1, 2026

Solved Problem

INS-drivers had errors and can't build.

Currently, INS-drivers buildability isn't checked when merging pull-requests.
After these changes b7c5ba1 it was stopped.

Because of this, build-errors in this code-base go unnoticed.

Solution

INS-drivers build fixed.
Clang-tidy errors fixed.
Code-style errors (astyle) fixed in the separate commits.

Build more targets in px4_sitl_allyes:
Exclude specific targets from build instead of redundant big filters COMMON and DRIVERS in Tools/kconfig/allyesconfig.py

Changelog Entry

For release notes:

Restore driver build coverage in px4_sitl_allyes (previously silently skipped)

@valbv valbv force-pushed the ins_fix branch 3 times, most recently from 826dc0d to 4d70217 Compare April 1, 2026 13:30
@valbv valbv marked this pull request as draft April 1, 2026 13:33
@valbv valbv force-pushed the ins_fix branch 12 times, most recently from 6499350 to 9ed3b8e Compare April 2, 2026 14:09
@valbv valbv marked this pull request as ready for review April 2, 2026 14:32
Copy link
Copy Markdown
Contributor

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good but I think in the case of the vectornav, it should just be excluded from clang-tidy and astyle. We don't want to force a change on their library.

Comment thread src/drivers/ins/ilabs/ILabs.h
Comment thread src/drivers/ins/microstrain/MicroStrain.cpp Outdated
Comment thread src/drivers/ins/microstrain/MicroStrain.cpp Outdated
Comment thread src/drivers/ins/vectornav/VectorNav.hpp
@valbv valbv marked this pull request as draft April 5, 2026 06:42
@valbv valbv force-pushed the ins_fix branch 3 times, most recently from 3a37f18 to fbd8f1e Compare April 5, 2026 07:37
@valbv valbv marked this pull request as ready for review April 5, 2026 07:58
@valbv
Copy link
Copy Markdown
Contributor Author

valbv commented Apr 5, 2026

If I disable clang-tidy checks for "libvnc" as all, the error: "Error: no checks enabled" occurs.
I left one memory leak check for it.

@valbv valbv requested a review from dakejahl April 9, 2026 08:26
dakejahl
dakejahl previously approved these changes Apr 13, 2026
Comment thread src/drivers/ins/sbgecom/CMakeLists.txt Outdated
Comment thread src/drivers/ins/sbgecom/CMakeLists.txt Outdated
Comment thread src/drivers/ins/vectornav/CMakeLists.txt Outdated
Comment thread src/drivers/ins/vectornav/VectorNav.cpp
@valbv valbv force-pushed the ins_fix branch 2 times, most recently from 0c80fef to 4933350 Compare April 24, 2026 17:04
@mrpollo mrpollo changed the title feat(Tools/kconfig/allyesconfig.py): Remove redundant filters from exception_list_sitl feat(allyes): Remove redundant filters from exception_list_sitl Apr 24, 2026
Comment thread src/drivers/vtxtable/VtxTable.cpp Outdated
@valbv valbv force-pushed the ins_fix branch 2 times, most recently from 6fcecb5 to 2b742a0 Compare April 24, 2026 18:46
@valbv valbv marked this pull request as ready for review April 24, 2026 18:47
mrpollo
mrpollo approved these changes Apr 24, 2026
Copy link
Copy Markdown
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allyes fix is exactly right. The bare COMMON/DRIVERS prefixes were silently eating every driver including UART-only ones, and the surgical exclusion list is the right shape. Restoring real CI coverage here also surfaced a backlog of legitimate driver fixes (vectornav missing brace, sbgecom short-read + leak, vtxtable open() mode, vertiq_io proper EINTR/EAGAIN handling) that were hiding behind that hole.

Rebase-merging this so the per-driver commits stay individually bisectable.

Thanks for picking this up and running it all the way through, @valbv.

@mrpollo mrpollo merged commit 7ac1cbd into PX4:main Apr 24, 2026
73 checks passed
@valbv
Copy link
Copy Markdown
Contributor Author

valbv commented Apr 24, 2026

Thank you guys!

@valbv valbv deleted the ins_fix branch April 24, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants