fix(sih): fix velocity in body direction#27390
Open
sfuhrer wants to merge 1 commit into
Open
Conversation
Signed-off-by: Silvan <silvan@auterion.com>
Contributor
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 168 byte (0.01 %)]px4_fmu-v6x [Total VM Diff: 0 byte (0 %)]Updated: 2026-05-19T07:09:36 |
mbjd
reviewed
May 19, 2026
|
|
||
| // pitot tube measures forward (body-x) airspeed | ||
| airspeed.true_airspeed_m_s = fmaxf(0.1f, _v_B(0) + generate_wgn() * 0.2f); | ||
| const Vector3f v_apparent_B = _q.rotateVectorInverse(_v_apparent_N); |
Contributor
There was a problem hiding this comment.
Looks correct - while we're at it we could also change the conversion in generate_force_and_torques to look the same (_q_E.rotateVectorInverse(_R_N2E * _v_apparent_N); is equivalent to this)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
See https://github.com/PX4/PX4-Autopilot/pull/27376/changes#r3264262813
Solution
Use the correct ground speed rotated to body frame.