feat(heater): add more temp sources & heating modes#27398
Draft
alexcekay wants to merge 1 commit into
Draft
Conversation
Contributor
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 1176 byte (0.06 %)]px4_fmu-v6x [Total VM Diff: 1168 byte (0.06 %)]Updated: 2026-05-19T16:48:40 |
dakejahl
approved these changes
May 20, 2026
Contributor
dakejahl
left a comment
There was a problem hiding this comment.
Very nice. Share some logs once you have them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
This addresses multiple topics observed while developing a more complex heater
sensor_accel.Solution
sensor_hygrometer. The structure also allows adding more sources in the futureHEATER_FAST_UPDATE_MODEtoKconfig. This allows using the last received temperature for up to a defined timeout where the heater will be turned off for safety reasons. The fast update is needed for slow temperature sources, otherwise the heater will be turned off most of the time and will not heat enough. If this is not set everything behaves as previouslyHEATER${I}_NOM_Vparameter. With this it is possible to set the nominal voltage the controller was designed. This is also the voltage the heater network can sustain with 100% duty cycle. A higher supply voltage will adapt the controller output accordingly to not overload the heater network. This requires reading supply voltage and will disable the heater when no supply voltage can be read. If the parameter is not set everything behaves as previously.Test coverage
HEATER_FAST_UPDATE_MODEwith a new product with a quite strong heater network