fix(stick_yaw): reset yaw setpoint when unaided yaw recovers#27411
Open
AkaiEurus wants to merge 1 commit into
Open
fix(stick_yaw): reset yaw setpoint when unaided yaw recovers#27411AkaiEurus wants to merge 1 commit into
AkaiEurus wants to merge 1 commit into
Conversation
dakejahl
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
Fixes a yaw setpoint discontinuity in
StickYawwhenunaided_yawrecovers after being unavailable.#25710 fixed the finite-to-NaN transition by preserving
_yaw_correctionwhileunaided_yawis not available. However, whenunaided_yawbecomes finite again, the yaw correction logic can still use stale yaw error filter/reference state from before the outage. This can apply an invalid correction delta to the locked yaw setpoint.Solution
Track whether
unaided_yawwas invalid during the previous update. When it becomes valid again, reset the yaw error filter/reference to the current yaw error, clear the stale correction state, and force the yaw lock to reinitialize from the current yaw.Added a regression test covering the
finite -> NaN -> finitetransition to ensure the yaw setpoint does not jump whenunaided_yawrecovers.Changelog Entry
For release notes:
Test coverage