Skip to content

[FIX] Preserve quoted statement literals#181

Draft
Mirochill wants to merge 1 commit into
PabloRMira:masterfrom
Mirochill:fix-178-quoted-on-literal
Draft

[FIX] Preserve quoted statement literals#181
Mirochill wants to merge 1 commit into
PabloRMira:masterfrom
Mirochill:fix-178-quoted-on-literal

Conversation

@Mirochill
Copy link
Copy Markdown

Reference Issue

Fixes #178

What does this implement/fix? Explain your changes.

  • Keeps main statement keyword formatting out of quoted string regions after the CREATE statement preformatting pass.
  • Adds notebook regression coverage for formatting select * from rooms where command = 'on' without changing the string literal.

Any other comments?

Validation:

  • git diff --check
  • Parsed nbs/00_core.ipynb and nbs/99_additional_tests.ipynb as JSON
  • Not run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'on' as a string literal is reformatted to '\n ON'

1 participant