Skip to content

Commit 3244a3d

Browse files
committed
[test] fix ci
1 parent 2276319 commit 3244a3d

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

fastdeploy/engine/common_engine.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1341,7 +1341,12 @@ def _insert_zmq_task_to_scheduler(self):
13411341
main_process_metrics.inc_value("requests_number")
13421342
main_process_metrics.inc_value("prompt_tokens_total", request.prompt_token_ids_len)
13431343
main_process_metrics.obs_value("request_prompt_tokens", request.prompt_token_ids_len)
1344-
main_process_metrics.obs_value("request_params_max_tokens", request.sampling_params.max_tokens)
1344+
if getattr(request, "sampling_params", None) and getattr(
1345+
request.sampling_params, "max_tokens", None
1346+
):
1347+
main_process_metrics.obs_value(
1348+
"request_params_max_tokens", request.sampling_params.max_tokens
1349+
)
13451350
trace_carrier = data.get("trace_carrier")
13461351
if trace_carrier:
13471352
request_id = get_base_request_id(data["request_id"])

tests/engine/test_common_engine.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1311,6 +1311,9 @@ class DummyMetrics:
13111311
def __init__(self):
13121312
self.requests_number = Mock(inc=Mock())
13131313
self.num_requests_waiting = Mock(inc=Mock())
1314+
self.prompt_tokens_total = Mock(inc=Mock())
1315+
self.request_prompt_tokens = Mock(observe=Mock())
1316+
self.request_params_max_tokens = Mock(observe=Mock())
13141317

13151318
def inc_value(self, name, value=1, labelvalues=None):
13161319
getattr(self, name).inc(value)
@@ -2727,6 +2730,8 @@ def close(self):
27272730
with patch("fastdeploy.engine.common_engine.Request") as MockRequest:
27282731
mock_request = Mock()
27292732
mock_request.metrics.scheduler_recv_req_time = 0
2733+
mock_request.prompt_token_ids_len = 2
2734+
mock_request.sampling_params = Mock(max_tokens=16)
27302735
MockRequest.from_dict.return_value = mock_request
27312736

27322737
with (
@@ -2756,6 +2761,8 @@ def close(self):
27562761
with patch("fastdeploy.engine.common_engine.Request") as MockRequest:
27572762
mock_request = Mock()
27582763
mock_request.metrics.scheduler_recv_req_time = 0
2764+
mock_request.prompt_token_ids_len = 2
2765+
mock_request.sampling_params = Mock(max_tokens=16)
27592766
MockRequest.from_dict.return_value = mock_request
27602767

27612768
with (
@@ -3359,6 +3366,9 @@ class DummyMetrics:
33593366
def __init__(self):
33603367
self.requests_number = Mock(inc=Mock())
33613368
self.num_requests_waiting = Mock(inc=Mock())
3369+
self.prompt_tokens_total = Mock(inc=Mock())
3370+
self.request_prompt_tokens = Mock(observe=Mock())
3371+
self.request_params_max_tokens = Mock(observe=Mock())
33623372

33633373
def inc_value(self, name, value=1, labelvalues=None):
33643374
getattr(self, name).inc(value)

0 commit comments

Comments
 (0)