-
Notifications
You must be signed in to change notification settings - Fork 738
[Cherry-Pick][Optimization] merge matmul and add (#6986) #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+12
−5
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9d83df2
merge matmul and add
BingooYang 954645b
modify format
BingooYang 272272c
using paddle.nn.functional.linear
BingooYang 70a0724
using _C_ops.linear
BingooYang 7ac2448
using paddle.nn.functional.linear
BingooYang a8ed2a1
add FLAGS_use_legacy_linear env var in test case
BingooYang c420da7
fix format
BingooYang 0c421b7
add assert and remove env
BingooYang 251eb4e
modify format
BingooYang 6acbde5
using matmul for no bias
BingooYang ddabdb1
modify accurate baseline
BingooYang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Bug 对于
paddle格式的模型,layer.weight的形状为[input_size, output_size],而paddle.nn.functional.linear期望的weight形状为(output_size, input_size)。根据代码分析:
torch格式:layer.weight形状为[output_size, input_size](在create_weights中转置)paddle格式:layer.weight形状为[input_size, output_size](未转置)UnquantizedLinearMethod的process_weights_after_loading会被跳过对于
paddle格式的模型,直接使用paddle.nn.functional.linear(x, layer.weight, bias)可能会导致形状不匹配错误。建议:
paddle格式模型的兼容性