Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check-bypass.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ jobs:

can_skip_docs=true
for f in $files; do
if [[ "$f" =~ ^\.claude/ || "$f" =~ ^benchmarks/ || "$f" =~ ^docs/ || "$f" =~ ^dockerfiles/ || "$f" =~ ^examples/ || "$f" =~ ^tools/ ]]; then

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug 这里把整个 benchmarks/dockerfiles/examples/tools/ 目录都当成 docs-only 跳过,会漏跑真实构建/测试风险。

check-only-docs 的结果在后续 final-output 中会直接变成 can-skip=true,而 _build_linux.yml_unit_test_coverage.yml_build_xpu.yml 等 job 都用 needs.check_bypass.outputs.can-skip != 'true' 控制执行。当前仓库这些目录包含 tools/dockerfile/Dockerfile.citools/deep_gemm_pre-compile/*.pydockerfiles/Dockerfile.gpuexamples/.../test.shbenchmarks/*.py 等可执行或构建相关文件;只要 PR 只改其中任意文件,就会跳过构建和测试,导致 runtime、镜像或示例脚本回归无法被 CI 捕获。

建议修复方式:
不要按目录整体 continue。把 docs-only 规则收敛为明确低风险文件类型/子路径,例如只允许 docs/**.claude/**、以及这些目录中的 *.md 文档文件跳过;对 *.py*.shDockerfile*requirements*.txt*.yaml 等会影响执行、构建或环境的文件保持 can_skip_docs=false

continue
fi
if [[ ! "$f" =~ \.(md|yaml|go)$ ]]; then
can_skip_docs=false
break
Expand Down