Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions fastdeploy/engine/common_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -1339,6 +1339,14 @@ def _insert_zmq_task_to_scheduler(self):

request.metrics.scheduler_recv_req_time = time.time()
main_process_metrics.inc_value("requests_number")
main_process_metrics.inc_value("prompt_tokens_total", request.prompt_token_ids_len)
main_process_metrics.obs_value("request_prompt_tokens", request.prompt_token_ids_len)
if getattr(request, "sampling_params", None) and getattr(
request.sampling_params, "max_tokens", None
):
main_process_metrics.obs_value(
"request_params_max_tokens", request.sampling_params.max_tokens
)
trace_carrier = data.get("trace_carrier")
if trace_carrier:
request_id = get_base_request_id(data["request_id"])
Expand Down
5 changes: 1 addition & 4 deletions fastdeploy/entrypoints/engine_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
log_request,
log_request_error,
)
from fastdeploy.metrics.metrics import main_process_metrics
from fastdeploy.platforms import current_platform
from fastdeploy.trace.constants import LoggingEventName
from fastdeploy.trace.trace_logger import print as trace_print
Expand Down Expand Up @@ -374,9 +373,7 @@ async def add_requests(self, task):

if "messages" in task:
task["messages"] = None
main_process_metrics.obs_value("request_params_max_tokens", task["max_tokens"])
main_process_metrics.inc_value("prompt_tokens_total", input_ids_len)
main_process_metrics.obs_value("request_prompt_tokens", input_ids_len)

except Exception as e:
log_request_error(
message="request[{request_id}] add_requests error: {error}, {traceback}",
Expand Down
10 changes: 10 additions & 0 deletions tests/engine/test_common_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -1311,6 +1311,9 @@ class DummyMetrics:
def __init__(self):
self.requests_number = Mock(inc=Mock())
self.num_requests_waiting = Mock(inc=Mock())
self.prompt_tokens_total = Mock(inc=Mock())
self.request_prompt_tokens = Mock(observe=Mock())
self.request_params_max_tokens = Mock(observe=Mock())

def inc_value(self, name, value=1, labelvalues=None):
getattr(self, name).inc(value)
Expand Down Expand Up @@ -2727,6 +2730,8 @@ def close(self):
with patch("fastdeploy.engine.common_engine.Request") as MockRequest:
mock_request = Mock()
mock_request.metrics.scheduler_recv_req_time = 0
mock_request.prompt_token_ids_len = 2
mock_request.sampling_params = Mock(max_tokens=16)
MockRequest.from_dict.return_value = mock_request

with (
Expand Down Expand Up @@ -2756,6 +2761,8 @@ def close(self):
with patch("fastdeploy.engine.common_engine.Request") as MockRequest:
mock_request = Mock()
mock_request.metrics.scheduler_recv_req_time = 0
mock_request.prompt_token_ids_len = 2
mock_request.sampling_params = Mock(max_tokens=16)
MockRequest.from_dict.return_value = mock_request

with (
Expand Down Expand Up @@ -3359,6 +3366,9 @@ class DummyMetrics:
def __init__(self):
self.requests_number = Mock(inc=Mock())
self.num_requests_waiting = Mock(inc=Mock())
self.prompt_tokens_total = Mock(inc=Mock())
self.request_prompt_tokens = Mock(observe=Mock())
self.request_params_max_tokens = Mock(observe=Mock())

def inc_value(self, name, value=1, labelvalues=None):
getattr(self, name).inc(value)
Expand Down
Loading