Skip to content

Fix wrong attribute and error message in _safe_extract_zip#78810

Merged
SigureMo merged 1 commit intoPaddlePaddle:developfrom
StatefulDust:fix-safe-extract-zip-error-msg
May 2, 2026
Merged

Fix wrong attribute and error message in _safe_extract_zip#78810
SigureMo merged 1 commit intoPaddlePaddle:developfrom
StatefulDust:fix-safe-extract-zip-error-msg

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 25, 2026

PR Category

User Experience

PR Types

Bug fixes

Description

Before, the _safe_extract_zip function's error msg is copyed from _safe_extract_tar, it will make a misunderstanding for user. And when zipFile format, ZipInfo has not a name attribute, only filename, it's a bug too.

是否引起精度变化

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Apr 25, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Apr 25, 2026
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2026

/re-run all-failed

3 similar comments
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 25, 2026

/re-run all-failed

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 26, 2026

/re-run all-failed

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 26, 2026

/re-run all-failed

Copy link
Copy Markdown
Contributor

@ooooo-create ooooo-create left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ooooo-create ooooo-create requested a review from SigureMo April 27, 2026 10:53
@SigureMo SigureMo changed the title Fix zip extraction traversal error message Fix wrong attribute and error message in _safe_extract_zip May 2, 2026
@SigureMo SigureMo merged commit f036e2c into PaddlePaddle:develop May 2, 2026
345 of 357 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants