update muon_sharding_optimizer with rebuilding 2d_params.#78814
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.67%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #78814 +/- ##
==========================================
Coverage ? 75.67%
==========================================
Files ? 2
Lines ? 37
Branches ? 0
==========================================
Hits ? 28
Misses ? 9
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
GuoxiaWang
previously approved these changes
Apr 28, 2026
sneaxiy
previously approved these changes
Apr 28, 2026
xxyux
force-pushed
the
rebuild_2d
branch
3 times, most recently
from
0115493 to
2e0fe37
Compare
Contributor
Author
|
/re-run all-failed |
2 similar comments
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
This PR introduces 2 main changes to refine the Muon optimizer implementation:
Removed hardcoded attributes specialized for specific colors (e.g.,
self._params_2d,self._params_2d_moe,self._rank2params_2d). Replaced them with a generalized loop (for color_key, params_2d in self._params_2d_by_color.items():) to make the color grouping mechanism template-based and highly extensible.Removed the reliance on the external environment variable
FLAGS_shard_fused_gradient. The logic is now dynamically and elegantly controlled by the internal attributeself._use_fuse_gradients = self.comm_buffer_size_MB > 0.是否引起精度变化
否