Skip to content

update muon_sharding_optimizer with rebuilding 2d_params.#78828

Merged
sneaxiy merged 4 commits into
PaddlePaddle:release/3.4from
xxyux:cherry-pick-muon-to-3.4
Apr 29, 2026
Merged

update muon_sharding_optimizer with rebuilding 2d_params.#78828
sneaxiy merged 4 commits into
PaddlePaddle:release/3.4from
xxyux:cherry-pick-muon-to-3.4

Conversation

@xxyux
Copy link
Copy Markdown
Contributor

@xxyux xxyux commented Apr 28, 2026

PR Category

Execute Infrastructure

PR Types

Improvements

Description

DevPR:#78814

是否引起精度变化

devPR:#78814

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Apr 28, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

GuoxiaWang
GuoxiaWang previously approved these changes Apr 28, 2026
sneaxiy
sneaxiy previously approved these changes Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxyux xxyux dismissed stale reviews from sneaxiy and GuoxiaWang via b386ea8 April 28, 2026 19:46
@xxyux
Copy link
Copy Markdown
Contributor Author

xxyux commented Apr 29, 2026

/re-run all-failed

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/3.4@1105c37). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...d/fleet/meta_optimizers/muon_sharding_optimizer.py 74.28% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.67%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff               @@
##             release/3.4   #78828   +/-   ##
==============================================
  Coverage               ?   75.67%           
==============================================
  Files                  ?        2           
  Lines                  ?       37           
  Branches               ?        0           
==============================================
  Hits                   ?       28           
  Misses                 ?        9           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for coverage.

@sneaxiy sneaxiy merged commit f2d2763 into PaddlePaddle:release/3.4 Apr 29, 2026
129 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants