Skip to content

fix dsa type notion#4504

Merged
xingmingyyj merged 1 commit into
PaddlePaddle:developfrom
xingmingyyj:fix_notion
May 22, 2026
Merged

fix dsa type notion#4504
xingmingyyj merged 1 commit into
PaddlePaddle:developfrom
xingmingyyj:fix_notion

Conversation

@xingmingyyj

Copy link
Copy Markdown
Collaborator

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

fix dsa type notion

@paddle-bot

paddle-bot Bot commented May 21, 2026

Copy link
Copy Markdown

Thanks for your contribution!

@CLAassistant

CLAassistant commented May 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-commenter

codecov-commenter commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@a8ab43b). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4504   +/-   ##
==========================================
  Coverage           ?   46.46%           
==========================================
  Files              ?      475           
  Lines              ?    90603           
  Branches           ?        0           
==========================================
  Hits               ?    42095           
  Misses             ?    48508           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xingmingyyj xingmingyyj reopened this May 21, 2026
@Paddle-CI-Bot

Paddle-CI-Bot commented May 21, 2026

Copy link
Copy Markdown

PaddleFormers Log Analysis

Run #26226257673 · Attempt 1

日志分析报告

流水线名称 问题标签 修复建议
CI_ILUVATAR 环境问题(container failed) 自托管 Runner 容器启动失败,与 PR 代码无关,建议 CI 维护人员检查 iluvatar-gpu-2 Runner 的 Docker 配置并 rerun。

失败的测试case:

test_ernie_21b_sft_training(scripts/iluvatar_ci/test_ernie_21b_sft.py)
— 未实际执行,因容器异常提前退出

根本原因分析:

两次 attempt 均触发相同的底层错误:

  • Attempt 1Run CI unittest 失败,仅耗时 26 秒):annotation 显示 "Executing the custom container implementation failed" + "Error: failed to run script step: [object Object]",容器在执行 Run CI unittest 步骤时崩溃,测试根本未运行。
  • Attempt 2Merge PR 失败):同一 annotation 错误,容器在更早的 Merge PR 步骤就已失败。

PR 本身的改动(dsa_indexer_loss_coeff: bool → float,仅 1 行类型注解修正)与测试配置 ERNIE-21B-SFT.yaml 完全无关,不会引发任何测试逻辑失败。同日其他多个 CI_ILUVATAR runs(#2143#2146#2147#2148)也均以相同方式失败,确认为 Runner 侧系统性故障。

修复建议:

  1. CI 维护人员:检查 iluvatar-gpu-2 自托管 Runner 上的 Docker/容器运行时状态,重启 Runner 服务或修复容器配置后,对 PR fix dsa type notion #4504 执行 rerun
  2. PR 作者:代码改动本身正确,无需修改,等待 Runner 恢复后 rerun 即可通过。

🔄 每次 Re-run 后自动更新

@xingmingyyj

Copy link
Copy Markdown
Collaborator Author

/re-run all-failed

@xingmingyyj xingmingyyj merged commit f3fc3f2 into PaddlePaddle:develop May 22, 2026
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants