Propagate Kimi accuracy-compatible flag to PaddleFleet provider#4747
Propagate Kimi accuracy-compatible flag to PaddleFleet provider#4747zrr1999 wants to merge 2 commits into
Conversation
risemeup1111
left a comment
There was a problem hiding this comment.
发现一个需要合入前处理的兼容性问题,已在行级评论中给出具体原因和建议修改。CI 当前还有任务在运行中,未作为本次阻塞依据。
| if getattr(config, "use_accuracy_compatible", False): | ||
| # PaddleFleet still uses this internal flag for several | ||
| # precision-alignment branches. Keep the public PaddleFormers | ||
| # knob as the single user-facing gate. | ||
| config.gpt_model_use_experimental_version = True |
There was a problem hiding this comment.
这里直接打开 gpt_model_use_experimental_version 会让 use_accuracy_compatible=True 的 Kimi-K2 在 sequence_parallel=True 时运行到 PaddleFleet 的断言:GPTEmbedding.forward 要求 experimental 版本下不能同时使用 multi_latent_attention 和 sequence parallel,而 Kimi-K2 在建 provider 前固定设置了 multi_latent_attention=True。这会把原本可配置的 TP/SP 训练路径变成首次 forward 才失败。请在映射内部标志前做显式兼容性校验(或补齐 PaddleFleet 支持),避免静默构造出必崩配置。
| if getattr(config, "use_accuracy_compatible", False): | |
| # PaddleFleet still uses this internal flag for several | |
| # precision-alignment branches. Keep the public PaddleFormers | |
| # knob as the single user-facing gate. | |
| config.gpt_model_use_experimental_version = True | |
| if getattr(config, "use_accuracy_compatible", False): | |
| if getattr(config, "sequence_parallel", False) and getattr(config, "multi_latent_attention", False): | |
| raise ValueError( | |
| "use_accuracy_compatible=True maps to PaddleFleet gpt_model_use_experimental_version, " | |
| "which does not support Kimi-K2 MLA with sequence_parallel=True." | |
| ) | |
| # PaddleFleet still uses this internal flag for several | |
| # precision-alignment branches. Keep the public PaddleFormers | |
| # knob as the single user-facing gate. | |
| config.gpt_model_use_experimental_version = True |
PaddleFormers Log Analysis
日志分析报告
失败的测试case: 根本原因分析: 修复建议:
🔄 每次 Re-run 后自动更新 |
|
Fixed in |
risemeup1111
left a comment
There was a problem hiding this comment.
复查了新提交,之前关于 use_accuracy_compatible=True 与 Kimi-K2 MLA/sequence parallel 组合的 P1 兼容性问题已经通过显式 ValueError 校验修复。当前代码改动对我来说可以接受。
CI 仍有任务在运行中,请以最终 CI 结果为准。
Summary
Validation