[cherry-pick][fix] internal_medicine_monitor_interval default to 0 (disabled)#4751
Merged
zjjlivein merged 1 commit intoJul 8, 2026
Conversation
PaddleFormers Log Analysis
日志分析报告
失败的测试case: 根本原因分析: 修复建议:
🔄 每次 Re-run 后自动更新 |
Backport of the trainer.py gate change from PaddlePaddle#4746 to release/1.2. Currently the callback is registered whenever internal_medicine_monitors is non-empty, ignoring internal_medicine_monitor_interval. When callers set monitors but leave interval at 0 (the "disable monitoring" default), the callback still runs and later crashes in _should_monitor with a ZeroDivisionError. Only the trainer gate is changed. Callback constructor is unchanged on release/1.2 (feature scaffolding differs from develop), so extra kwargs like qk_row_stride / log_dir are intentionally not backported here. Merged in dev: PaddlePaddle#4746
9f8c9e6 to
eaa3c3b
Compare
zjjlivein
approved these changes
Jul 8, 2026
zjjlivein
left a comment
Collaborator
There was a problem hiding this comment.
lgtm : CI精度diff 是已知问题
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged in dev: #4746
Backport of #4746 to release/1.2.
Manually resolved conflicts in: