Fix user_deprovision: use is_success from python-pagerduty SDK#145
Open
gian25-work wants to merge 1 commit into
Open
Fix user_deprovision: use is_success from python-pagerduty SDK#145gian25-work wants to merge 1 commit into
gian25-work wants to merge 1 commit into
Conversation
The pdpyras→python-pagerduty migration switched the underlying HTTP client; the response object exposes is_success (httpx-style) rather than the requests-style ok attribute, so delete_user always raised AttributeError on success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdpyrastopython-pagerduty(commit 89b773f),DeleteUser.delete_userstill returnsr.ok.is_success, not the requests-styleokattribute, sodelete_userraisesAttributeErroron every successful deletion.r.okwithr.is_successinuser_deprovision/user_deprovision.py.Test plan
user_deprovision.pyagainst a test PagerDuty account and confirm a user is deleted withoutAttributeError.Trueon a successful delete (HTTP 2xx).